Remove optimiseSpacefinderInline test and set changes live (#1572)

guardian · Sep 4, 2024 · 2ac0ee8 · 2ac0ee8
1 parent a0283db
commit 2ac0ee8
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 41 deletions.
diff --git a/.changeset/dry-pumpkins-brake.md b/.changeset/dry-pumpkins-brake.md
@@ -0,0 +1,5 @@
+---
+'@guardian/commercial': minor
+---
+
+Remove `optimiseSpacefinderInline` test and set changes live
diff --git a/src/experiments/ab-tests.ts b/src/experiments/ab-tests.ts
@@ -1,7 +1,6 @@
 import type { ABTest } from '@guardian/ab-core';
 import { mpuWhenNoEpic } from './tests/mpu-when-no-epic';
 import { optOutFrequencyCap } from './tests/opt-out-frequency-cap';
-import { optimiseSpacefinderInline } from './tests/optimise-spacefinder-inline';
 
 /**
  * You only need to add tests to this file if the code you are testing is here in
@@ -12,5 +11,4 @@ export const concurrentTests: ABTest[] = [
 	// one test per line
 	mpuWhenNoEpic,
 	optOutFrequencyCap,
-	optimiseSpacefinderInline,
 ];
diff --git a/src/experiments/tests/optimise-spacefinder-inline.ts b/src/experiments/tests/optimise-spacefinder-inline.ts
diff --git a/src/insert/spacefinder/rules.ts b/src/insert/spacefinder/rules.ts
@@ -1,7 +1,5 @@
 import { adSizes } from 'core';
 import { adSlotContainerClass } from 'core/create-ad-slot';
-import { isUserInVariant } from 'experiments/ab';
-import { optimiseSpacefinderInline } from 'experiments/tests/optimise-spacefinder-inline';
 import type { OpponentSelectorRules, SpacefinderRules } from './spacefinder';
 import { isInHighValueSection } from './utils';
 
@@ -43,11 +41,6 @@ const inlineOpponentSelector = ['inline', 'supporting', 'showcase']
 
 const headingSelector = `:scope > h2, [data-spacefinder-role="nested"] > h2, :scope > h3, [data-spacefinder-role="nested"] > h3`;
 
-const isInInlineSpacefinderOptimisationTest = isUserInVariant(
-	optimiseSpacefinderInline,
-	'variant',
-);
-
 const desktopInline1: SpacefinderRules = {
 	bodySelector,
 	candidateSelector,
@@ -65,15 +58,15 @@ const desktopInline1: SpacefinderRules = {
 		},
 		[inlineOpponentSelector]: {
 			marginBottom: 35,
-			marginTop: isInInlineSpacefinderOptimisationTest ? 200 : 400,
+			marginTop: 200,
 		},
 		[leftColumnOpponentSelector]: {
-			marginBottom: isInInlineSpacefinderOptimisationTest ? 50 : 35,
-			marginTop: isInInlineSpacefinderOptimisationTest ? 100 : 400,
+			marginBottom: 50,
+			marginTop: 100,
 		},
 		[rightColumnOpponentSelector]: {
 			marginBottom: 0,
-			marginTop: isInInlineSpacefinderOptimisationTest ? 150 : 600,
+			marginTop: 150,
 		},
 		['[data-spacefinder-role="supporting"]']: {
 			marginBottom: 0,