Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update thrift library #171

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Update thrift library #171

merged 2 commits into from
Jul 4, 2024

Conversation

fredex42
Copy link
Contributor

@fredex42 fredex42 commented Jul 3, 2024 •
edited
Loading

No model changes; simply bumps Thrift Node library to current latest 0.20.0 (Apr 2024)

@fredex42 fredex42 requested review from a team as code owners July 3, 2024 09:42
@gu-scala-library-release
Copy link
Contributor

@fredex42 has published a preview version of this PR with release workflow run #17, based on commit edc833a:

4.0.5-PREVIEW.agbump-thrift.2024-07-03T0944.edc833ab

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the ag/bump-thrift branch, or use the GitHub CLI command:

gh workflow run release.yml --ref ag/bump-thrift

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@fredex42 fredex42 changed the title No model changes; simply bumps Thrift Node library to current latest 0.20.0 (Apr 2024) Update thrift library Jul 3, 2024
@gu-scala-library-release
Copy link
Contributor

@fredex42 has published a preview version of this PR with release workflow run #18, based on commit 08ee988:

5.0.0-PREVIEW.agbump-thrift.2024-07-03T1000.08ee9887

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the ag/bump-thrift branch, or use the GitHub CLI command:

gh workflow run release.yml --ref ag/bump-thrift

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

emdash-ie
emdash-ie approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@emdash-ie emdash-ie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming you’ve tested the preview release you made

@fredex42 fredex42 merged commit 2800867 into main Jul 4, 2024
9 checks passed
@fredex42 fredex42 deleted the ag/bump-thrift branch July 4, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emdash-ie emdash-ie emdash-ie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredex42 @emdash-ie