-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support fixing image sizes at tablet and desktop #12572
Merged
Merged
+110
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmockett
added
run_chromatic
Runs chromatic when label is applied
and removed
dotcom-rendering
labels
Oct 17, 2024
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 17, 2024
Size Change: +168 B (+0.02%) Total Size: 928 kB
ℹ️ View Unchanged
|
jamesmockett
commented
Oct 17, 2024
jamesmockett
force-pushed
the
jm/card-fixed-image-sizes
branch
from
October 17, 2024 15:52
d8c2001
to
a9e436b
Compare
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 17, 2024
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
jamesmockett
requested review from
abeddow91,
cemms1 and
Georges-GNM
and removed request for
a team
October 17, 2024 17:14
jamesmockett
force-pushed
the
jm/card-fixed-image-sizes
branch
2 times, most recently
from
October 18, 2024 17:10
3daf9cb
to
96fe6c1
Compare
abeddow91
approved these changes
Oct 24, 2024
jamesmockett
force-pushed
the
jm/card-fixed-image-sizes
branch
2 times, most recently
from
October 25, 2024 13:40
f2ebb0c
to
e3c3a01
Compare
jamesmockett
force-pushed
the
jm/card-fixed-image-sizes
branch
from
October 28, 2024 09:41
e3c3a01
to
1ec4ef2
Compare
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 28, 2024
Seen on PROD (merged by @jamesmockett 9 minutes and 49 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
imageFixedSizes
prop toImageWrapper
, allowing fixed image sizes to be specified formobile
,tablet
anddesktop
breakpointsisFlexibleContainer
prop fromImageWrapper
and moves logic up toCard
componentCardLayout
Why?
Image sizes were already fixed below
tablet
with a custom size for flexible containers toggled by theisFlexibleContainer
prop onImageWrapper
. Fixed image sizes are also required for other containers such as scrollable small which, unlike the flexible containers, has fixed images sizes at all breakpoints.Screenshots