Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new layout for audio page #12676

Merged
merged 41 commits into from
Oct 25, 2024
Merged

Add new layout for audio page #12676

merged 41 commits into from
Oct 25, 2024

Conversation

oliverabrahams
Copy link
Contributor

@oliverabrahams oliverabrahams commented Oct 24, 2024

What does this change?

  • Add a new layout file for the audio articles (podcasts)
  • Moves Audio player up the grid

Why?

  • Moving audio page rendering from FE to DCR.

Screenshots

Before After
before after
before2 after2
before3 after3

Co-authored by @sndrs

oliverabrahams and others added 27 commits October 2, 2024 12:13
# Conflicts:
#	dotcom-rendering/src/layouts/StandardLayout.tsx
# Conflicts:
#	dotcom-rendering/src/components/Picture.tsx
#	dotcom-rendering/src/layouts/StandardLayout.tsx
# Conflicts:
#	dotcom-rendering/src/components/ArticleMeta.web.tsx
…layout-audio-page

# Conflicts:
#	dotcom-rendering/src/components/AudioPlayer/AudioPlayer.tsx
#	dotcom-rendering/src/components/AudioPlayer/components/Playback.tsx
#	dotcom-rendering/src/components/Picture.tsx
@sndrs sndrs added this to the Decommission Frontend Rendering milestone Oct 24, 2024
@sndrs sndrs linked an issue Oct 24, 2024 that may be closed by this pull request
@sndrs sndrs marked this pull request as ready for review October 24, 2024 16:45
@sndrs sndrs requested a review from a team as a code owner October 24, 2024 16:45
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Oct 25, 2024
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Oct 25, 2024
@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label Oct 25, 2024
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Oct 25, 2024
@oliverabrahams oliverabrahams merged commit 58998f6 into main Oct 25, 2024
32 checks passed
@oliverabrahams oliverabrahams deleted the e2e/layout-audio-page branch October 25, 2024 11:47
@prout-bot
Copy link

Seen on PROD (merged by @oliverabrahams 8 minutes and 48 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Create audio page layout
3 participants