Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YoutubeAtom implement fullscreen for Android #12705

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −2
Draft

YoutubeAtom implement fullscreen for Android #12705

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6551c0
Reenable external_fullscreen
arelra Oct 28, 2024
96eb0da
Use safe viewport width and height for apps fullscreen
arelra Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions dotcom-rendering/src/components/YoutubeAtom/YoutubeAtomPlayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ const fullscreenStyles = (id: string) => css`
position: fixed;
top: 0;
left: 0;
width: 100vw;
height: 100vh;
width: 100svw;
height: 100svh;
z-index: ${getZIndex('youTubeFullscreen')};
}
`;
Expand Down Expand Up @@ -465,6 +465,9 @@ export const YoutubeAtomPlayer = ({
videoId,
playerVars: {
controls: 1,
// @ts-expect-error -- advised by YouTube for Android but does not exist in @types/youtube
external_fullscreen:
renderingTarget === 'Apps' ? 1 : 0,
fs: 1,
modestbranding: 1,
origin,
Expand Down
Loading