Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suppressImages to fronts tool settings #325

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

Georges-GNM
Copy link
Contributor

@Georges-GNM Georges-GNM commented Sep 25, 2024

What does this change?

Part of this ticket: we are adding a new container with two variations - one with all images suppressed and one with optional images (including cutouts). We'll use this new value in the fronts tool to indicate when a collection should show images.

How to test

Tested with a work in progress fronts tool PR.

How can we measure success?

Have we considered potential risks?

Images

Accessibility

Deployment

  • Updated facia-tool to use latest version
  • Updated frontend to use latest version
  • Updated MAPI to use latest version
  • Updated Ophan to use latest version
  • Updated story-packages to use latest version
  • Updated apple-news to use latest version
  • Checked for other downstream dependencies (perhaps via snyk or github search)

@Georges-GNM Georges-GNM marked this pull request as ready for review September 25, 2024 09:38
@gu-scala-library-release
Copy link
Contributor

@Georges-GNM has published a preview version of this PR with release workflow run #37, based on commit 79973a0:

11.0.0-PREVIEW.gladd-suppress-images-property.2024-09-25T0940.79973a0d

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the gl/add-suppress-images-property branch, or use the GitHub CLI command:

gh workflow run release.yml --ref gl/add-suppress-images-property

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@gu-scala-library-release
Copy link
Contributor

@Georges-GNM has published a preview version of this PR with release workflow run #38, based on commit d2af950:

11.0.0-PREVIEW.gladd-suppress-images-property.2024-09-26T1303.d2af9509

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the gl/add-suppress-images-property branch, or use the GitHub CLI command:

gh workflow run release.yml --ref gl/add-suppress-images-property

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@Georges-GNM Georges-GNM changed the title Add suppressImages to collection config Add suppressImages to fronts tool settings Sep 30, 2024
@Georges-GNM Georges-GNM merged commit 82dac9d into main Sep 30, 2024
10 checks passed
@Georges-GNM Georges-GNM deleted the gl/add-suppress-images-property branch September 30, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants