Add suppressImages prop #1672
Merged
Add suppressImages prop #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemms1
previously approved these changes
Sep 30, 2024
11 tasks
Georges-GNM
changed the title
…se it to display a message on the collection if images are suppressed
Georges-GNM
commented
Oct 3, 2024
| @@ -279,6 +279,11 @@ | |||
| <label for="frontsToolSettings.displayEditWarning">Display edit warning</label> | |||
| <input id="hideShowMore" type="checkbox" data-bind="checked: meta.frontsToolSettings.displayEditWarning" /> | |||
|
|
|||
| <!-- ko if: meta.type() === 'scrollable/small' --> | |||
There was a problem hiding this comment.
I've limited it to scrollable small here - I guess we'll want it for scrollable medium too? Will have another PR for some more changes to make in this file, so could update then.
There was a problem hiding this comment.
Let's keep in scrollable small for now. This may be required on other containers but will confirm what's wanted before we do
cemms1
approved these changes
Oct 7, 2024
| @@ -279,6 +279,11 @@ | |||
| <label for="frontsToolSettings.displayEditWarning">Display edit warning</label> | |||
| <input id="hideShowMore" type="checkbox" data-bind="checked: meta.frontsToolSettings.displayEditWarning" /> | |||
|
|
|||
| <!-- ko if: meta.type() === 'scrollable/small' --> | |||
There was a problem hiding this comment.
Let's keep in scrollable small for now. This may be required on other containers but will confirm what's wanted before we do
|
Seen on PROD (merged by @Georges-GNM 9 minutes and 48 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Part of this ticket: we are adding a new container with two variations - one with all images suppressed and one with optional images (including cutouts).
This requires adding a property to a collection's config (by way of this new facia-scala-client release) which will be subsequently used to determine if a collection shows images or not.
Implementation notes
A subsequent PR will properly implement the property (so that, e.g. the image gets faded), but for the moment we're satisfied with displaying as:
Checklist
General
Client