-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add suppressImages prop #1672
Add suppressImages prop #1672
Conversation
…se it to display a message on the collection if images are suppressed
@@ -279,6 +279,11 @@ | |||
<label for="frontsToolSettings.displayEditWarning">Display edit warning</label> | |||
<input id="hideShowMore" type="checkbox" data-bind="checked: meta.frontsToolSettings.displayEditWarning" /> | |||
|
|||
<!-- ko if: meta.type() === 'scrollable/small' --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've limited it to scrollable small here - I guess we'll want it for scrollable medium too? Will have another PR for some more changes to make in this file, so could update then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep in scrollable small for now. This may be required on other containers but will confirm what's wanted before we do
@@ -279,6 +279,11 @@ | |||
<label for="frontsToolSettings.displayEditWarning">Display edit warning</label> | |||
<input id="hideShowMore" type="checkbox" data-bind="checked: meta.frontsToolSettings.displayEditWarning" /> | |||
|
|||
<!-- ko if: meta.type() === 'scrollable/small' --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep in scrollable small for now. This may be required on other containers but will confirm what's wanted before we do
Seen on PROD (merged by @Georges-GNM 9 minutes and 48 seconds ago) Please check your changes! |
What's changed?
Part of this ticket: we are adding a new container with two variations - one with all images suppressed and one with optional images (including cutouts).
This requires adding a property to a collection's config (by way of this new facia-scala-client release) which will be subsequently used to determine if a collection shows images or not.
Implementation notes
A subsequent PR will properly implement the property (so that, e.g. the image gets faded), but for the moment we're satisfied with displaying as:
Checklist
General
Client