Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit Sentry logging for error responses from the recipe search api #1694

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

fredex42
Copy link
Contributor

What's changed?

Add explicit Sentry logging for error responses from the recipe search api.

If there are any transient issues with the search api, we need to know about them before we start trying to integrate to the main app. Since this is the only place it's in use at the moment, we want to get detailed information about any potential failures.

Implementation notes

n/a

Checklist

General

  • 🤖 Relevant tests added n/a
  • ✅ CI checks / tests run locally
  • 🔍 Checked on CODE

Client

  • 🚫 No obvious console errors on the client (i.e. React dev mode errors)
  • 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
  • 📷 Screenshots / GIFs of relevant UI changes included n/a

@fredex42 fredex42 requested a review from a team as a code owner October 14, 2024 16:38
Copy link
Member

@JustinPinner JustinPinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fredex42 fredex42 merged commit ec715c0 into main Oct 21, 2024
12 checks passed
@fredex42 fredex42 deleted the ag/report-searchapi-failures branch October 21, 2024 11:15
@prout-bot
Copy link

Seen on PROD (merged by @fredex42 7 minutes and 33 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants