Recrop option to disable if image is not from Grid #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Divs-B
commented
Oct 16, 2024
| @@ -257,6 +257,8 @@ interface ComponentState { | |||
| const dragImage = new Image(); | |||
| dragImage.src = imageDragIcon; | |||
|
|
|||
| const regexToCheckGridImage: RegExp = /^https?:\/\/(www\.)?media\.(?:dev-|)guim\.co\.uk\/([0-9a-fA-F]+)\//; | |||
There was a problem hiding this comment.
Thanks to @fredex42 for suggesting regex to check endpoint to distinguish between endpoint poiting to grid or pointing to normal s3 uploader (like chef's image)
Co-authored-by: Emily Bourke <emily.bourke@guardian.co.uk>
Divs-B
changed the title
|
Checked with CoPro team as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Recrop Imageoption from Chef card because we found that the image is not available on the grid to edit on. At present chef images are uploaded on S3.Note: Need to check with CoPro team on using
Recrop Imagewhen article has author's cutout images. I thinkrecropwill not be working on those images too.Before:
On CHEF card
Screen.Recording.2024-10-16.at.17.38.29.mov
On UK Daily Edition, one of the article
Screen.Recording.2024-10-16.at.17.57.48.mov
After:
On CHEF card
Screen.Recording.2024-10-16.at.15.05.45.mov
On UK Daily Edition, one of the article
Screen.Recording.2024-10-16.at.18.03.34.mov
Implementation notes
Checklist
General
Client