-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recrop option to disable if image is not from Grid #1698
Conversation
@@ -257,6 +257,8 @@ interface ComponentState { | |||
const dragImage = new Image(); | |||
dragImage.src = imageDragIcon; | |||
|
|||
const regexToCheckGridImage: RegExp = /^https?:\/\/(www\.)?media\.(?:dev-|)guim\.co\.uk\/([0-9a-fA-F]+)\//; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to @fredex42 for suggesting regex to check endpoint to distinguish between endpoint poiting to grid or pointing to normal s3 uploader (like chef's image)
Co-authored-by: Emily Bourke <emily.bourke@guardian.co.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Checked with CoPro team as well. |
What's changed?
Recrop Image
option from Chef card because we found that the image is not available on the grid to edit on. At present chef images are uploaded on S3.Note: Need to check with CoPro team on using
Recrop Image
when article has author's cutout images. I thinkrecrop
will not be working on those images too.Before:
On CHEF card
Screen.Recording.2024-10-16.at.17.38.29.mov
On UK Daily Edition, one of the article
Screen.Recording.2024-10-16.at.17.57.48.mov
After:
On CHEF card
Screen.Recording.2024-10-16.at.15.05.45.mov
On UK Daily Edition, one of the article
Screen.Recording.2024-10-16.at.18.03.34.mov
Implementation notes
Checklist
General
Client