fix newsletter image types

guardian · May 17, 2024 · 791e29e · 791e29e
1 parent c324ee7
commit 791e29e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/src/client/pages/NewAccountNewsletters.tsx b/src/client/pages/NewAccountNewsletters.tsx
@@ -1,6 +1,10 @@
 import React from 'react';
 import { MainLayout } from '@/client/layouts/Main';
-import { NewsLetter, Newsletters } from '@/shared/model/Newsletter';
+import {
+	NewsLetter,
+	Newsletters,
+	NewslettersWithImages,
+} from '@/shared/model/Newsletter';
 import { palette, space, textSans } from '@guardian/source-foundations';
 import { css } from '@emotion/react';
 import {
@@ -46,7 +50,7 @@ const labelStyles = css`
 	}
 `;
 
-const newsletterIdToImagePath: Record<Newsletters, string> = {
+const newsletterIdToImagePath: Record<NewslettersWithImages, string> = {
 	[Newsletters.DOWN_TO_EARTH]: DOWN_TO_EARTH_IMAGE,
 	[Newsletters.FIRST_EDITION_UK]: FIRST_EDITION_UK_IMAGE,
 	[Newsletters.THE_LONG_READ]: THE_LONG_READ_IMAGE,
@@ -104,7 +108,9 @@ export const NewAccountNewsletters = ({
 									context={newsletter.description}
 									cssOverrides={labelStyles}
 									imagePath={
-										newsletterIdToImagePath[newsletter.id as Newsletters]
+										newsletterIdToImagePath[
+											newsletter.id as NewslettersWithImages
+										]
 									}
 									onToggle={handleCheckboxChange}
 								/>

diff --git a/src/shared/model/Newsletter.ts b/src/shared/model/Newsletter.ts
@@ -33,6 +33,11 @@ export enum Newsletters {
 	US_BUNDLE = 'usBundle',
 }
 
+export type NewslettersWithImages =
+	| Newsletters.DOWN_TO_EARTH
+	| Newsletters.FIRST_EDITION_UK
+	| Newsletters.THE_LONG_READ;
+
 export const ALL_NEWSLETTER_IDS = Object.values(Newsletters);
 
 type RegistrationNewsletterFormIds =