use react's useId in place of generateSourceId

it does not change when the component is rerendered
guardian · May 24, 2024 · b3202ef · b3202ef
1 parent e0c9fba
commit b3202ef
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/client/components/CheckboxInput.tsx b/src/client/components/CheckboxInput.tsx
@@ -1,12 +1,11 @@
-import React from 'react';
+import React, { useId } from 'react';
 import type { EmotionJSX } from '@emotion/react/types/jsx-namespace';
 import { Checkbox } from '@guardian/source-react-components';
 import { SerializedStyles, css } from '@emotion/react';
 import {
 	textSans,
 	focusHalo,
 	descriptionId,
-	generateSourceId,
 	space,
 	palette,
 	textSans12,
@@ -126,7 +125,7 @@ export const CheckboxInput = ({
 	cssOverrides,
 	onToggle,
 }: CheckboxInputProps): EmotionJSX.Element => {
-	const switchName = id ?? generateSourceId();
+	const switchName = id ?? useId();
 	const labelId = descriptionId(switchName);
 
 	return (

diff --git a/src/client/components/ToggleSwitchInput.tsx b/src/client/components/ToggleSwitchInput.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+import React, { useId } from 'react';
 import type { EmotionJSX } from '@emotion/react/types/jsx-namespace';
 import type { Props } from '@guardian/source-react-components';
 import { css } from '@emotion/react';
@@ -9,7 +9,6 @@ import {
 	focusHalo,
 	visuallyHidden,
 	descriptionId,
-	generateSourceId,
 	space,
 } from '@guardian/source-foundations';
 
@@ -174,7 +173,7 @@ export const ToggleSwitchInput = ({
 	imagePath,
 	cssOverrides,
 }: ToggleSwitchInputProps): EmotionJSX.Element => {
-	const switchName = id ?? generateSourceId();
+	const switchName = id ?? useId();
 	const labelId = descriptionId(switchName);
 
 	return (