Fix missing Janus creds error in Dev mode #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldlink
approved these changes
Aug 3, 2023
pvighi
reviewed
Aug 3, 2023
| if ( | ||
| error.name === 'CredentialsProviderError' && | ||
| stage === 'DEV' | ||
| ) { |
There was a problem hiding this comment.
did the error change with a new version of the aws library or something ?
pvighi
approved these changes
Aug 3, 2023
coldlink
force-pushed
the
vb/fix-dev-awscreds-error
branch
from
c0c13ea
to
db89f3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Ensures the DEV error message about missing AWS janus credentials is printed.