-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passwordless | ResetPasswordEmailSentPage
and API refactors
#2881
Conversation
ResetPasswordEmailSentPage
and API refactors
|
||
if (!hasRemediation && useThrow) { | ||
throw new Error( | ||
// eslint-disable-next-line @typescript-eslint/restrict-template-expressions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is needed as typescript doesn't think that remediationName
is a string type that it can put into a template expression even though it is, the tests above prove that: https://github.com/guardian/gateway/pull/2881/files#diff-b996cc3a1711f22fd1ace11e046c019d10b7e7d74ed0c8a2f4caa3750b9d3946R78
ed60018
to
ccd554e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ccd554e
to
acca665
Compare
What does this change?
ResetPasswordEmailSentPage
component that displays the correct page based on whether we're using passcodes or the legacy link methodhasStateHandle
variable, then we show thePasscodeEmailSent
componentPasscodeUsed
componentEmailSent
component as previously donechallengeAuthenticatorSchema
toshared/schemas.ts
as it's also needed by theidentifyRemediations
type toovalidate<ENDPOINT>Remediation
methods into a single method calledvalidateRemediation
which takes type genericsvalidateChallengeAnswerRemediation
it becomesinstead of