Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies | 23rd September 2024 #2908

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Dependencies | 23rd September 2024 #2908

merged 1 commit into from
Sep 23, 2024

Conversation

coldlink
Copy link
Member

@coldlink coldlink commented Sep 23, 2024 •
edited
Loading

What does this change?

Updates dependencies where possible since #2899

Also runs knip to remove unused exports.

Holds back the following:

  • Eslint to v9 - needs a configuration change, possibly even for the project to switch to using ESM
  • Sentry to v8 - major version upgrade, need to do in a separate PR i.e Dependencies | Update sentry to v8 #2903
  • @types/node - Stick to v20, until we upgrade to Node 22 LTS when that's released
  • Storybook - Issues with preact/react in 8.3.x will investigate separately

Tested

  • CODE

@coldlink coldlink requested a review from a team as a code owner September 23, 2024 08:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

Deploy build 10030 of identity:identity-gateway to CODE

All deployment options

From guardian/actions-riff-raff.

@coldlink coldlink requested review from guardian-ci and removed request for guardian-ci September 23, 2024 09:21
@coldlink coldlink added the dependencies Pull requests that update a dependency file label Sep 23, 2024
akinsola-guardian
akinsola-guardian approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@akinsola-guardian akinsola-guardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coldlink coldlink merged commit 82f20b2 into main Sep 23, 2024
20 checks passed
@coldlink coldlink deleted the mm/deps-2024-09-23 branch September 23, 2024 11:09
@coldlink coldlink mentioned this pull request Sep 30, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akinsola-guardian akinsola-guardian akinsola-guardian approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coldlink @akinsola-guardian