-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook | Fix issue with 8.3.x
#2945
Conversation
…k/preact-webpack5`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find 👍
"@storybook/react": "^8.2.9", | ||
"@storybook/react-webpack5": "^8.2.9", | ||
"@storybook/preact-webpack5": "^8.3.5", | ||
"@storybook/react": "^8.3.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we possibly want to use the @storybook/preact package here instead aswell?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried removing @storybook/react
dependency, and everything seems to work, so I'll make a PR just to remove it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I'll leave it as @storybook/react
for now, and if it breaks in the future, we can deal with it then!
What does this change?
For a while now we haven't been able to update storybook as we've been getting an error when attempting to run storybook after upgrading to
8.3.x
Specifically
Finally investigating this, it seems to be a change with the
@storybook/react-webpack5
package. Despite aliasing everything to preact, there must've been a change where it's looking for thetest-utils
export on thereact
namespace and not thereact/test-utils
namespace as aliased.Preact doesn't export the
test-utils
on thepreact/compat
namespace, so storybook failed to build when it couldn't find the export.Switching to the
@storybook/preact-webpack5
seems to help!