improve log messages and remove println

guardian · Oct 4, 2024 · 610c558 · 610c558
1 parent 9e20507
commit 610c558
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/backend/app/extraction/ExternalTranscriptionExtractor.scala b/backend/app/extraction/ExternalTranscriptionExtractor.scala
@@ -110,7 +110,7 @@ class ExternalTranscriptionExtractor(index: Index, transcribeConfig: TranscribeC
     transcriptionJob.flatMap {
       job => {
         try {
-          logger.info(s"sending message to ${transcribeConfig.transcriptionServiceQueueUrl}")
+          logger.info(s"sending message to Transcription Service Queue")
 
           val sendMessageCommand = new SendMessageRequest()
             .withQueueUrl(transcribeConfig.transcriptionServiceQueueUrl)

diff --git a/backend/app/extraction/ExternalTranscriptionWorker.scala b/backend/app/extraction/ExternalTranscriptionWorker.scala
@@ -19,11 +19,14 @@ import scala.jdk.CollectionConverters.CollectionHasAsScala
 class ExternalTranscriptionWorker(manifest: WorkerManifest, amazonSQSClient: AmazonSQS, transcribeConfig: TranscribeConfig, blobStorage: ObjectStorage, index: Index)(implicit executionContext: ExecutionContext)  extends Logging{
 
   def pollForResults(): Int  = {
+    logger.info("Fetching messages from external transcription output queue")
     val messages = amazonSQSClient.receiveMessage(
       new ReceiveMessageRequest(transcribeConfig.transcriptionOutputQueueUrl).withMaxNumberOfMessages(10)
     ).getMessages
 
-    if (messages.size() > 0) logger.info(s"retrieved ${messages.size()} messages from queue ${transcribeConfig.transcriptionOutputQueueUrl}")
+    if (messages.size() > 0)
+      logger.info(s"retrieved ${messages.size()} messages from queue Transcription Output Queue")
+    else logger.info("No message found")
 
     messages.asScala.toList.foldLeft(0) { (completed, message) =>
       val result = for {

diff --git a/backend/app/services/ExternalWorkerScheduler.scala b/backend/app/services/ExternalWorkerScheduler.scala
@@ -21,12 +21,10 @@ class ExternalWorkerScheduler(actorSystem: ActorSystem, worker: ExternalTranscri
 
   def go(): Unit = {
     try {
-      println("running ExternalWorkerScheduler")
       val completed = worker.pollForResults()
       if (completed > 0) {
         go()
       } else {
-        println(s"try again ExternalWorkerScheduler in ${interval}")
         tryAgainIn(interval)
       }
     } catch {