Merge pull request #146 from guardian/pm-show-error-icon-ingestfail

Show error icon in events dashboard for non-extractor errors
guardian · Oct 2, 2023 · 958316e · 958316e
2 parents 0b19ba6 + 14e2b5e
commit 958316e
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/frontend/src/js/components/IngestionEvents/IngestionEvents.tsx b/frontend/src/js/components/IngestionEvents/IngestionEvents.tsx
@@ -62,8 +62,12 @@ const statusIconColumn = {
         field: 'extractorStatuses',
         name: '',
         width: '40',
-        render: (statuses: ExtractorStatus[]) => {
-            return blobStatusIcons[getBlobStatus(statuses)]
+        render: (statuses: ExtractorStatus[], row: BlobStatus) => {
+            const totalErrors = row.errors.length
+            const extractorStatus = getBlobStatus(statuses)
+            // if extractors have finished but there are other non-extractor related errors, show an error icon
+            const combinedStatus = extractorStatus === "complete" && totalErrors > 0 ? "completeWithErrors" : extractorStatus
+            return blobStatusIcons[combinedStatus]
         }
     }