Fix _isValidMessage check

[bryophyta]

What does this change?

The _isValidMessage check was diffing two different things: Set<string> and Set<string[]> so it was always failing afaict: https://logs.gutools.co.uk/s/editorial-tools/app/r/s/XpbfG

How to test

• Deploy to CODE
• Send a valid message via the lambda console, check that the failure message is no longer logged, and that the work still continues.
• Send an invalid message, check that the failure message is logged and work ceases.

Valid message

{
  "Records": [
    {
      "kinesis": {
        "data": "ICAgIHsidHlwZSI6InByb2plY3QtdXBkYXRlZCIsImlkIjoiMjc5NzciLCJ0aXRsZSI6IlRlc3QgdGl0bGUiLCJzdGF0dXMiOiJJbiBQcm9kdWN0aW9uIiwiY29tbWlzc2lvbklkIjoiNDM4MSIsImNvbW1pc3Npb25UaXRsZSI6IlRvZGF5IGluIEZvY3VzIERlY2VtYmVyIDIwMjQiLCJwcm9kdWN0aW9uT2ZmaWNlIjoiVUsiLCJjcmVhdGVkIjoiMjAyNC0xMi0xMVQxMTo0MTowMC40MDYwMDArMDA6MDAifQ=="
      }
    }
  ]
}

Invalid message

(same payload as valid, except the 'id' field is remove):

{
  "Records": [
    {
      "kinesis": {
        "data": "eyJ0eXBlIjoicHJvamVjdC11cGRhdGVkIiwidGl0bGUiOiJUZXN0IHRpdGxlIiwic3RhdHVzIjoiSW4gUHJvZHVjdGlvbiIsImNvbW1pc3Npb25JZCI6IjQzODEiLCJjb21taXNzaW9uVGl0bGUiOiJUb2RheSBpbiBGb2N1cyBEZWNlbWJlciAyMDI0IiwicHJvZHVjdGlvbk9mZmljZSI6IlVLIiwiY3JlYXRlZCI6IjIwMjQtMTItMTFUMTE6NDE6MDAuNDA2MDAwKzAwOjAwIn0="
      }
    }
  ]
}

How can we measure success?

Have we considered potential risks?

Images

Accessibility

• Tested with screen reader
• Navigable with keyboard
• Colour contrast passed
• The change doesn't use only colour to convey meaning

[andrew-nowak]

ohhhh great catch! Can we add a return to line 64 as well so this validation actually stops the processing from continuing :D

[prout-bot]

Seen on PROD (merged by @bryophyta 6 minutes and 24 seconds ago) Please check your changes!