Use setup-scala to provide sbt #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbt has been removed from Github's base images. The recommendation from DevX is to switch to using the setup-scala action to set up Java and Scala, along with sbt.
davidfurey
approved these changes
Dec 11, 2024
bryophyta
commented
Dec 11, 2024
| @@ -15,13 +15,12 @@ jobs: | |||
| with: | |||
| role-to-assume: ${{ secrets.GU_RIFF_RAFF_ROLE_ARN }} | |||
| aws-region: eu-west-1 | |||
| - uses: actions/setup-java@v3 | |||
| with: | |||
There was a problem hiding this comment.
the new action will look at .tool-versions to get the java version, but this file already exists and matches the value specified here (corretto 11), although it's pinned to a specific patch version.
|
Seen on PROD (merged by @bryophyta 6 minutes and 25 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sbt has been removed from Github's base images. The recommendation from DevX is to switch to using the setup-scala action to set up Java and Scala, along with sbt.
See amiable for a prior example.
There's already a
.tool-versionsfile in this repo so we don't need to add one here.What does this change?
How to test
How can we measure success?
Have we considered potential risks?
Images
Accessibility