Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setup-scala to provide sbt #1182

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Use setup-scala to provide sbt #1182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,12 @@ jobs:
with:
role-to-assume: ${{ secrets.GU_RIFF_RAFF_ROLE_ARN }}
aws-region: eu-west-1
- uses: actions/setup-java@v3
with:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new action will look at .tool-versions to get the java version, but this file already exists and matches the value specified here (corretto 11), although it's pinned to a specific patch version.

java-version: "11"
distribution: "corretto"
# See https://github.com/guardian/setup-java
- name: Setup Java and sbt
uses: guardian/setup-scala@v1
- uses: actions/setup-node@v3
with:
node-version-file: '.nvmrc'
node-version-file: ".nvmrc"
- name: Build Pluto lambda
run: |
./scripts/pluto-ci.sh
Expand All @@ -31,5 +30,3 @@ jobs:
- name: Compile Scala and upload artifacts to RiffRaff
run: |
./scripts/scala-ci.sh


Loading