feat: re-enable create your account and tidy-up

guardian · Oct 23, 2024 · 35d9d63 · 35d9d63
1 parent cb0d73e
commit 35d9d63
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/support-frontend/assets/components/thankYou/newspaperArchive/newspaperArchiveImage.tsx b/support-frontend/assets/components/thankYou/newspaperArchive/newspaperArchiveImage.tsx
@@ -26,8 +26,8 @@ const desktopImg = css`
 	display: none;
 	height: auto;
 	margin-left: auto;
-	margin-top: -${space[4]}px;
-	margin-bottom: -${space[5]}px;
+	margin-top: -${space[2]}px; // padding-top over-run
+	margin-bottom: -${space[5]}px; // padding-bottom over-run
 
 	& img {
 		width: 100%;

diff --git a/support-frontend/assets/components/thankYou/thankYouModule.tsx b/support-frontend/assets/components/thankYou/thankYouModule.tsx
@@ -102,7 +102,6 @@ const bodyContainer = css`
 `;
 const sizeContainer = css`
 	z-index: 1;
-	width: 100%;
 	${between.tablet.and.desktop} {
 		width: 330px;
 	}
@@ -156,9 +155,9 @@ const appContainer = css`
 const imgContainer = css`
 	grid-area: img;
 	align-self: flex-end;
-	margin-top: ${space[2]}px;
 `;
 const sizeImgContainer = css`
+	margin-top: ${space[2]}px;
 	${until.tablet} {
 		margin-top: ${space[4]}px;
 	}

diff --git a/support-frontend/assets/pages/[countryGroupId]/components/thankyou.tsx b/support-frontend/assets/pages/[countryGroupId]/components/thankyou.tsx
@@ -215,10 +215,7 @@ export function ThankYouComponent({
 	): ThankYouModuleType[] => (condition ? [moduleType] : []);
 
 	const thankYouModules: ThankYouModuleType[] = [
-		...maybeThankYouModule(
-			isNewAccount && !showNewspaperArchiveBenefit,
-			'signUp',
-		), // Create your Guardian account
+		...maybeThankYouModule(isNewAccount, 'signUp'), // Create your Guardian account
 		...maybeThankYouModule(!isNewAccount && !isSignedIn, 'signIn'), // Sign in to access your benefits
 		...maybeThankYouModule(isTier3, 'benefits'),
 		...maybeThankYouModule(isTier3, 'subscriptionStart'),