From 35d9d63f6450c3a15728b611fe9c3e01710f334f Mon Sep 17 00:00:00 2001 From: Paul Dempsey <76729591+paul-daniel-dempsey@users.noreply.github.com> Date: Wed, 23 Oct 2024 14:00:30 +0100 Subject: [PATCH] feat: re-enable create your account and tidy-up --- .../thankYou/newspaperArchive/newspaperArchiveImage.tsx | 4 ++-- .../assets/components/thankYou/thankYouModule.tsx | 3 +-- .../assets/pages/[countryGroupId]/components/thankyou.tsx | 5 +---- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/support-frontend/assets/components/thankYou/newspaperArchive/newspaperArchiveImage.tsx b/support-frontend/assets/components/thankYou/newspaperArchive/newspaperArchiveImage.tsx index 7fa99ed7e9..9443450c34 100644 --- a/support-frontend/assets/components/thankYou/newspaperArchive/newspaperArchiveImage.tsx +++ b/support-frontend/assets/components/thankYou/newspaperArchive/newspaperArchiveImage.tsx @@ -26,8 +26,8 @@ const desktopImg = css` display: none; height: auto; margin-left: auto; - margin-top: -${space[4]}px; - margin-bottom: -${space[5]}px; + margin-top: -${space[2]}px; // padding-top over-run + margin-bottom: -${space[5]}px; // padding-bottom over-run & img { width: 100%; diff --git a/support-frontend/assets/components/thankYou/thankYouModule.tsx b/support-frontend/assets/components/thankYou/thankYouModule.tsx index a17f80c029..163859d727 100644 --- a/support-frontend/assets/components/thankYou/thankYouModule.tsx +++ b/support-frontend/assets/components/thankYou/thankYouModule.tsx @@ -102,7 +102,6 @@ const bodyContainer = css` `; const sizeContainer = css` z-index: 1; - width: 100%; ${between.tablet.and.desktop} { width: 330px; } @@ -156,9 +155,9 @@ const appContainer = css` const imgContainer = css` grid-area: img; align-self: flex-end; - margin-top: ${space[2]}px; `; const sizeImgContainer = css` + margin-top: ${space[2]}px; ${until.tablet} { margin-top: ${space[4]}px; } diff --git a/support-frontend/assets/pages/[countryGroupId]/components/thankyou.tsx b/support-frontend/assets/pages/[countryGroupId]/components/thankyou.tsx index 398590eb35..74ead4d06f 100644 --- a/support-frontend/assets/pages/[countryGroupId]/components/thankyou.tsx +++ b/support-frontend/assets/pages/[countryGroupId]/components/thankyou.tsx @@ -215,10 +215,7 @@ export function ThankYouComponent({ ): ThankYouModuleType[] => (condition ? [moduleType] : []); const thankYouModules: ThankYouModuleType[] = [ - ...maybeThankYouModule( - isNewAccount && !showNewspaperArchiveBenefit, - 'signUp', - ), // Create your Guardian account + ...maybeThankYouModule(isNewAccount, 'signUp'), // Create your Guardian account ...maybeThankYouModule(!isNewAccount && !isSignedIn, 'signIn'), // Sign in to access your benefits ...maybeThankYouModule(isTier3, 'benefits'), ...maybeThankYouModule(isTier3, 'subscriptionStart'),