-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QM Generic Checkout Updates : Payment Method Selected #6406
Conversation
Size Change: +54 B (0%) Total Size: 2.32 MB ℹ️ View Unchanged
|
function sendEventContributionPaymentMethod( | ||
paymentMethod: PaymentMethod | null, | ||
function sendEventPaymentMethodSelected( | ||
paymentMethod: PaymentMethod | 'StripeExpressCheckoutElement' | null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PaymentMethod
type is starting to feel like a code smell, maybe it will become clearer once we remove the old checkouts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah agreed, this was copy & paste of a work around applied on the generic checkout, but certainly we could do with revisiting this when we start removing the old checkouts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Seen on PROD (merged by @GHaberis 13 minutes and 19 seconds ago)
Sentry Release: support-client-side, support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
What are you doing in this PR?
This PR applies some QM tracking that was omitted from the generic checkout on initial build...
sendEventContributionPaymentMethod
tosendEventPaymentMethodSelected
, so it's less "Contribution" specific.sendEventPaymentMethodSelected
to indicate payment method selected.sendEventPaymentMethodSelected
to indicate "StripeExpressCheckoutElement" payment method selected.These changes have been made across the generic checkout for Tier 1-3 and the new one-off checkout.
Trello Card