QM Generic Checkout Updates : Payment Method Selected #6406
+25
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +54 B (0%) Total Size: 2.32 MB ℹ️ View Unchanged
|
| function sendEventContributionPaymentMethod( | ||
| paymentMethod: PaymentMethod | null, | ||
| function sendEventPaymentMethodSelected( | ||
| paymentMethod: PaymentMethod | 'StripeExpressCheckoutElement' | null, |
There was a problem hiding this comment.
This PaymentMethod type is starting to feel like a code smell, maybe it will become clearer once we remove the old checkouts
There was a problem hiding this comment.
Yeah agreed, this was copy & paste of a work around applied on the generic checkout, but certainly we could do with revisiting this when we start removing the old checkouts.
|
Seen on PROD (merged by @GHaberis 13 minutes and 19 seconds ago)
Sentry Release: support-client-side, support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
This PR applies some QM tracking that was omitted from the generic checkout on initial build...
sendEventContributionPaymentMethodtosendEventPaymentMethodSelected, so it's less "Contribution" specific.sendEventPaymentMethodSelectedto indicate payment method selected.sendEventPaymentMethodSelectedto indicate "StripeExpressCheckoutElement" payment method selected.These changes have been made across the generic checkout for Tier 1-3 and the new one-off checkout.
Trello Card