-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Tag Manager: Send through Tier1/2/3/OneTime products for trigger identification #6428
Merged
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-daniel-dempsey
changed the title
feat: productType sent to GoogleTagManager
GoogleTagManager: Send through Tier1/2/3 and OneTime Products
Oct 18, 2024
paul-daniel-dempsey
changed the title
GoogleTagManager: Send through Tier1/2/3 and OneTime Products
GoogleTagManager: Send through Tier1/2/3/OneTime products for trigger identification
Oct 18, 2024
Size Change: +9 B (0%) Total Size: 2.29 MB ℹ️ View Unchanged
|
GHaberis
reviewed
Oct 18, 2024
paul-daniel-dempsey
changed the title
GoogleTagManager: Send through Tier1/2/3/OneTime products for trigger identification
Google Tag Manager: Send through Tier1/2/3/OneTime products for trigger identification
Oct 18, 2024
Probably plan to put this live Monday now as I believe must go in conjunction with the saved GoogleTagManager chnages. |
rupertbates
reviewed
Oct 21, 2024
rupertbates
reviewed
Oct 21, 2024
support-frontend/assets/pages/supporter-plus-thank-you/supporterPlusThankYou.tsx
Outdated
Show resolved
Hide resolved
GHaberis
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Seen on PROD (merged by @paul-daniel-dempsey 10 minutes and 53 seconds ago)
Sentry Release: support-client-side, support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
Google Tag Manager
Tags Defined here
Background PR here
NOTE : When PR goes in, GoogleTagManager batched changes must be saved.
Trello Card
How to test
Google Tag Manager