Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Tag Manager: Send through Tier1/2/3/OneTime products for trigger identification #6428

Merged
merged 7 commits into from
Oct 22, 2024
Merged

Google Tag Manager: Send through Tier1/2/3/OneTime products for trigger identification #6428

merged 7 commits into from
Oct 22, 2024
+8 −4

Conversation

paul-daniel-dempsey
Copy link
Contributor

@paul-daniel-dempsey paul-daniel-dempsey commented Oct 18, 2024 •
edited
Loading

What are you doing in this PR?

Google Tag Manager

  • Send through Tier1/2/3/OneTime products for trigger identification
  • For recurring, now sends through FinalAmount (incl promoCode adjustment).

Tags Defined here
Background PR here

NOTE : When PR goes in, GoogleTagManager batched changes must be saved.

Trello Card

How to test

Google Tag Manager

  • SetUp Tags (Conversion Id+Label)
  • Setup Triggers (configure custom event fields, link back to defined tags)
  • Preview with checkout links

@paul-daniel-dempsey paul-daniel-dempsey changed the title feat: productType sent to GoogleTagManager GoogleTagManager: Send through Tier1/2/3 and OneTime Products Oct 18, 2024
@paul-daniel-dempsey paul-daniel-dempsey changed the title GoogleTagManager: Send through Tier1/2/3 and OneTime Products GoogleTagManager: Send through Tier1/2/3/OneTime products for trigger identification Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024 •
edited
Loading

Deploy build 11733 of support::stripe-patrons-data to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024 •
edited
Loading

Deploy build 20997 of support:support-workers-mono to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024 •
edited
Loading

Size Change: +9 B (0%)

Total Size: 2.29 MB

ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 112 kB 0 B
./public/compiled-assets/javascripts/[countryGroupId]/router.js 258 kB +4 B (0%)
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB 0 B
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 242 kB 0 B
./public/compiled-assets/javascripts/downForMaintenancePage.js 69.3 kB 0 B
./public/compiled-assets/javascripts/error404Page.js 69.2 kB 0 B
./public/compiled-assets/javascripts/error500Page.js 69.1 kB 0 B
./public/compiled-assets/javascripts/favicons.js 617 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 195 kB 0 B
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 85.8 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPage.js 67.6 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 72.1 kB 0 B
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 71.4 kB 0 B
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 126 kB 0 B
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 311 kB +5 B (0%)
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 192 kB 0 B
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 85.7 kB 0 B
./public/compiled-assets/webpack/136.js 2.17 kB 0 B
./public/compiled-assets/webpack/187.js 21.5 kB 0 B
./public/compiled-assets/webpack/344.js 2.01 kB 0 B
./public/compiled-assets/webpack/671.js 21.8 kB 0 B
./public/compiled-assets/webpack/706.js 107 kB 0 B

compressed-size-action

@paul-daniel-dempsey paul-daniel-dempsey requested a review from a team October 18, 2024 13:21
@paul-daniel-dempsey paul-daniel-dempsey changed the title GoogleTagManager: Send through Tier1/2/3/OneTime products for trigger identification Google Tag Manager: Send through Tier1/2/3/OneTime products for trigger identification Oct 18, 2024
@paul-daniel-dempsey
Copy link
Contributor Author

Probably plan to put this live Monday now as I believe must go in conjunction with the saved GoogleTagManager chnages.

@paul-daniel-dempsey paul-daniel-dempsey requested a review from a team October 21, 2024 10:45
GHaberis
GHaberis approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@GHaberis GHaberis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@paul-daniel-dempsey paul-daniel-dempsey merged commit 18955df into main Oct 22, 2024
18 checks passed
@paul-daniel-dempsey paul-daniel-dempsey deleted the pd/google-tag-manager-tiers-setup branch October 22, 2024 09:20
@prout-bot
Copy link

Seen on PROD (merged by @paul-daniel-dempsey 10 minutes and 53 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rupertbates rupertbates rupertbates left review comments

@GHaberis GHaberis GHaberis approved these changes

Assignees
No one assigned
Labels
Seen-on-PROD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paul-daniel-dempsey @prout-bot @rupertbates @GHaberis