Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit users on the Contributions Only checkout from the coverTransactionCost test #6429

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

GHaberis
Copy link
Contributor

@GHaberis GHaberis commented Oct 18, 2024

What are you doing in this PR?

We have a "Contributions Only" checkout flow for some countries: eg. https://support.theguardian.com/int/contribute?country=OM

We shouldn't be bucketing users on this "Contributions Only" checkout flow in the coverTransactionCost A/B/C test because this checkout doesn't show the one-time choice cards component on the checkout page, which means we users allocated to variantB will never see the cover transaction component as it sits in this component.

Copy link
Contributor

Size Change: +9 B (0%)

Total Size: 2.28 MB

ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 112 kB +1 B (0%)
./public/compiled-assets/javascripts/[countryGroupId]/router.js 258 kB +1 B (0%)
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB +2 B (0%)
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 241 kB 0 B
./public/compiled-assets/javascripts/downForMaintenancePage.js 69.1 kB 0 B
./public/compiled-assets/javascripts/error404Page.js 69.1 kB +1 B (0%)
./public/compiled-assets/javascripts/error500Page.js 69 kB 0 B
./public/compiled-assets/javascripts/favicons.js 617 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 195 kB +1 B (0%)
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 85.6 kB +1 B (0%)
./public/compiled-assets/javascripts/payPalErrorPage.js 67.4 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 72 kB 0 B
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 71.2 kB +1 B (0%)
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 125 kB 0 B
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 310 kB 0 B
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 192 kB +1 B (0%)
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 85.5 kB 0 B
./public/compiled-assets/webpack/136.js 2.17 kB 0 B
./public/compiled-assets/webpack/187.js 21.3 kB 0 B
./public/compiled-assets/webpack/344.js 2.01 kB 0 B
./public/compiled-assets/webpack/671.js 21.8 kB 0 B
./public/compiled-assets/webpack/706.js 107 kB 0 B

compressed-size-action

Copy link
Contributor

@paul-daniel-dempsey paul-daniel-dempsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry I missed that, thanks George.

@GHaberis GHaberis merged commit 4b10927 into main Oct 18, 2024
18 checks passed
@GHaberis GHaberis deleted the gh-coverTransactionCost branch October 18, 2024 15:11
@GHaberis
Copy link
Contributor Author

GHaberis commented Oct 18, 2024

Ah, sorry I missed that, thanks George.

It's OK, we had it set up like this on the original test too but it wasn't an issue for that test as we'd positioned the cover transaction component at the bottom only, so it appeared correctly for the variant across all flows.

@prout-bot
Copy link

Seen on PROD (merged by @GHaberis 10 minutes and 54 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants