Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newspaper Archive : Benefit copy, visual updates, thankyou component #6432

Merged
merged 10 commits into from
Oct 23, 2024

Conversation

paul-daniel-dempsey
Copy link
Contributor

@paul-daniel-dempsey paul-daniel-dempsey commented Oct 21, 2024

What are you doing in this PR?

Update:

  • Landing Page Updates (see screenshot)
  • Benefit copy differs between ROW & UK
  • Tooltip Update
  • Thank-you Page Component and Copy

Requirements

Trello Card

How to test

https://support.thegulocal.com/uk/contribute#ab-newspaperArchiveBenefit=v1
https://support.thegulocal.com/uk/contribute#ab-newspaperArchiveBenefit=v2
https://support.thegulocal.com/uk/contribute#ab-newspaperArchiveBenefit=control

V1 V2
image image

Thankyou component

mobile desktop
image image

@paul-daniel-dempsey paul-daniel-dempsey changed the title Newspaper Archive : Benefit copy, visual updates, thabkyou component Newspaper Archive : Benefit copy, visual updates, thankyou component Oct 21, 2024
Copy link
Contributor

github-actions bot commented Oct 21, 2024

Size Change: -1.38 kB (-0.06%)

Total Size: 2.29 MB

Filename Size Change
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 241 kB -799 B (-0.33%)
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 194 kB -1.06 kB (-0.54%)
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 312 kB +843 B (+0.27%)
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 191 kB -1.08 kB (-0.56%)
ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 112 kB 0 B
./public/compiled-assets/javascripts/[countryGroupId]/router.js 259 kB +345 B (+0.13%)
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB 0 B
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/downForMaintenancePage.js 69.3 kB 0 B
./public/compiled-assets/javascripts/error404Page.js 69.2 kB 0 B
./public/compiled-assets/javascripts/error500Page.js 69.1 kB 0 B
./public/compiled-assets/javascripts/favicons.js 617 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 85.8 kB +97 B (+0.11%)
./public/compiled-assets/javascripts/payPalErrorPage.js 67.6 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 72.1 kB 0 B
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 71.5 kB +88 B (+0.12%)
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 126 kB +95 B (+0.08%)
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 85.8 kB +94 B (+0.11%)
./public/compiled-assets/webpack/136.js 2.17 kB 0 B
./public/compiled-assets/webpack/187.js 21.5 kB 0 B
./public/compiled-assets/webpack/344.js 2.01 kB 0 B
./public/compiled-assets/webpack/671.js 21.8 kB 0 B
./public/compiled-assets/webpack/706.js 107 kB 0 B

compressed-size-action

Copy link
Contributor

@andrewHEguardian andrewHEguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design looks great 👍 nice!

@paul-daniel-dempsey paul-daniel-dempsey merged commit b192f86 into main Oct 23, 2024
18 checks passed
@paul-daniel-dempsey paul-daniel-dempsey deleted the pd/newspaper-archive-copy branch October 23, 2024 13:17
@prout-bot
Copy link

Seen on PROD (merged by @paul-daniel-dempsey 10 minutes and 56 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants