-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only throw missing Billing State error if required by checkout's country group #6435
Merged
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewHEguardian
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Size Change: +16 B (0%) Total Size: 2.29 MB ℹ️ View Unchanged
|
Seen on PROD (merged by @GHaberis 20 minutes and 31 seconds ago)
Sentry Release: support-client-side, support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
We're logging an error in Sentry if a user pays with a wallet payment method, but that payment method does not have a Billing State associated to it. Currently we throw this error in all country group id regions, however it's only an issue we care about in countries that require Billing State, eg. US, CA, AU.
This PR updates the code that logs this issue, so we only report in the US, CA, AU. This will give us a better idea of how many users are experiencing an issue due to the missing Billing State.
Note: The objective here is to get a clearer picture of how many users are affected by a known issue where they're in the US, CA, AU but the Billing Address associated with their "wallet" payment method does not have a Billing State. Although we send
countryId
tologException
this info is impossible to find/filer on in Sentry's UI (I've tried!), otherwise I could have used that to help estimate the impact of this issue.