Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only throw missing Billing State error if required by checkout's country group #6435

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

GHaberis
Copy link
Contributor

@GHaberis GHaberis commented Oct 22, 2024

What are you doing in this PR?

We're logging an error in Sentry if a user pays with a wallet payment method, but that payment method does not have a Billing State associated to it. Currently we throw this error in all country group id regions, however it's only an issue we care about in countries that require Billing State, eg. US, CA, AU.

This PR updates the code that logs this issue, so we only report in the US, CA, AU. This will give us a better idea of how many users are experiencing an issue due to the missing Billing State.

Note: The objective here is to get a clearer picture of how many users are affected by a known issue where they're in the US, CA, AU but the Billing Address associated with their "wallet" payment method does not have a Billing State. Although we send countryId to logException this info is impossible to find/filer on in Sentry's UI (I've tried!), otherwise I could have used that to help estimate the impact of this issue.

@GHaberis GHaberis requested a review from a team October 22, 2024 10:08
Copy link
Contributor

@andrewHEguardian andrewHEguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

github-actions bot commented Oct 22, 2024

Size Change: +16 B (0%)

Total Size: 2.29 MB

ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 112 kB 0 B
./public/compiled-assets/javascripts/[countryGroupId]/router.js 258 kB +16 B (+0.01%)
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB 0 B
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 242 kB 0 B
./public/compiled-assets/javascripts/downForMaintenancePage.js 69.3 kB 0 B
./public/compiled-assets/javascripts/error404Page.js 69.2 kB 0 B
./public/compiled-assets/javascripts/error500Page.js 69.1 kB 0 B
./public/compiled-assets/javascripts/favicons.js 617 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 195 kB 0 B
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 85.8 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPage.js 67.6 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 72.1 kB 0 B
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 71.4 kB 0 B
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 126 kB 0 B
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 311 kB 0 B
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 192 kB 0 B
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 85.7 kB 0 B
./public/compiled-assets/webpack/136.js 2.17 kB 0 B
./public/compiled-assets/webpack/187.js 21.5 kB 0 B
./public/compiled-assets/webpack/344.js 2.01 kB 0 B
./public/compiled-assets/webpack/671.js 21.8 kB 0 B
./public/compiled-assets/webpack/706.js 107 kB 0 B

compressed-size-action

@GHaberis GHaberis merged commit 9bc5d2d into main Oct 22, 2024
18 checks passed
@GHaberis GHaberis deleted the gh-countryGroupIdsRequiringBillingState branch October 22, 2024 10:35
@prout-bot
Copy link

Seen on PROD (merged by @GHaberis 20 minutes and 31 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants