-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One Time Checkout - validation message #6442
Conversation
Size Change: +7 B (0%) Total Size: 2.29 MB ℹ️ View Unchanged
|
paymentMethod === 'Stripe' && | ||
stripe && | ||
cardElement && | ||
recaptchaToken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't actually produce a validation message but does require the token to proceed with card payment. This puts us at parity with the generic checkout. Let's try add a message as part of this ticket: https://trello.com/c/jcYuEiiR/1112-investigate-validation-on-generic-checkout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, looks like it comes up with Please check the 'Im not a robot' checkbox
with this anyway
paymentResult.paymentStatus === 'failure' | ||
) { | ||
setErrorContext(appropriateErrorMessage(paymentResult.error ?? '')); | ||
if (paymentResult) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep undefined is assumed failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Seen on PROD (merged by @andrewHEguardian 8 minutes and 45 seconds ago)
Sentry Release: support-client-side, support |
What are you doing in this PR?
Only show "Something went wrong" message when payment has been attempted. Also move this message to the right place.
Unset payment method validation on selection of a payment method.
Trello Card
Why are you doing this?
Fixing some bugs found in end to end testing
Screenshots
Something went wrong:
Before (when should not show)
After (when should not show)
After (when should show)
Payment Method Validation unset
Before
After