One Time Checkout - validation message #6442
Merged
+36
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +7 B (0%) Total Size: 2.29 MB ℹ️ View Unchanged
|
| paymentMethod === 'Stripe' && | ||
| stripe && | ||
| cardElement && | ||
| recaptchaToken |
There was a problem hiding this comment.
This doesn't actually produce a validation message but does require the token to proceed with card payment. This puts us at parity with the generic checkout. Let's try add a message as part of this ticket: https://trello.com/c/jcYuEiiR/1112-investigate-validation-on-generic-checkout
There was a problem hiding this comment.
Ok, looks like it comes up with Please check the 'Im not a robot' checkbox with this anyway
| paymentResult.paymentStatus === 'failure' | ||
| ) { | ||
| setErrorContext(appropriateErrorMessage(paymentResult.error ?? '')); | ||
| if (paymentResult) { |
There was a problem hiding this comment.
Yep undefined is assumed failure
|
Seen on PROD (merged by @andrewHEguardian 8 minutes and 45 seconds ago)
Sentry Release: support-client-side, support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
Only show "Something went wrong" message when payment has been attempted. Also move this message to the right place.
Unset payment method validation on selection of a payment method.
Trello Card
Why are you doing this?
Fixing some bugs found in end to end testing
Screenshots
Something went wrong:
Before (when should not show)
After (when should not show)
After (when should show)
Payment Method Validation unset
Before
After
