Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QM : Report checkout value from checkouts #6445

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

GHaberis
Copy link
Contributor

@GHaberis GHaberis commented Oct 28, 2024

What are you doing in this PR?

Objective: Report checkout value from generic checkout and new one-time checkout.

This PR does not cover:

  • Reporting checkout value from the 3-tier landing page
  • Firing the conversion events from the generic checkout and new one-time checkout.

These can be tackled in follow-up PRs.

DONE:

  • Create sendEventCheckoutValue function [DONE]
  • Call sendEventCheckoutValue function on generic checkout Tier 1/2/3 page load [DONE]

TODO:

  • Call sendEventCheckoutValue function on new one-time checkout page load
  • Call sendEventCheckoutValue on new one-time checkout amount change (eg. via amounts selection component)

TODO with Options

Option 1 (Delete old sendEventContributionCartValue function):

  • Delete old sendEventContributionCartValue function
  • Delete references to old sendEventContributionCartValue in support-frontend/assets/helpers/redux/checkout/product/contributionsSideEffects.ts

Pros: Less code
Cons: This will mean we no longer report Contribution Cart value on the 2-step checkout, which currently affects:

  • Existing one-time checkout
  • "Contributions Only" checkout

Option 2 (Keep old sendEventContributionCartValue function):

  • Keep calling old sendEventContributionCartValue from 2-step checkout

Pros: Continues reporting checkout value from 2-step
Cons: Multiple functions doing kind of the same thing, which is a bit confusing, we could label up the code which can be deleted once the 2-step checkout is deleted.

Option 3 (Replace old sendEventContributionCartValue function):

  • Replace calls to old sendEventContributionCartValue with calls to new sendEventCheckoutValue

Pros: Less code as we can delete old code
Cons: Will run into type issues trying to get new sendEventCheckoutValue function working with old/new checkouts

Trello Card

Copy link
Contributor

github-actions bot commented Oct 28, 2024

Size Change: -631 B (-0.03%)

Total Size: 2.29 MB

ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 112 kB -23 B (-0.02%)
./public/compiled-assets/javascripts/[countryGroupId]/router.js 259 kB +11 B (0%)
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB 0 B
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 242 kB -247 B (-0.1%)
./public/compiled-assets/javascripts/downForMaintenancePage.js 69.3 kB -7 B (-0.01%)
./public/compiled-assets/javascripts/error404Page.js 69.3 kB -5 B (-0.01%)
./public/compiled-assets/javascripts/error500Page.js 69.2 kB -9 B (-0.01%)
./public/compiled-assets/javascripts/favicons.js 617 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 195 kB -3 B (0%)
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 85.9 kB -11 B (-0.01%)
./public/compiled-assets/javascripts/payPalErrorPage.js 67.7 kB -3 B (0%)
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 72.2 kB -6 B (-0.01%)
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 71.5 kB -2 B (0%)
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 126 kB +6 B (0%)
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 311 kB -313 B (-0.1%)
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 192 kB -15 B (-0.01%)
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 85.8 kB -4 B (0%)
./public/compiled-assets/webpack/136.js 2.17 kB 0 B
./public/compiled-assets/webpack/187.js 21.6 kB 0 B
./public/compiled-assets/webpack/344.js 2.01 kB 0 B
./public/compiled-assets/webpack/671.js 21.8 kB 0 B
./public/compiled-assets/webpack/706.js 107 kB 0 B

compressed-size-action

@GHaberis GHaberis changed the title QM Updates QM : Report checkout value from checkouts Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant