-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QM : Report checkout value from checkouts #6445
Open
GHaberis
wants to merge
4
commits into
main
Choose a base branch
from
gh-qm-sendEventCheckoutValue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+191
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -631 B (-0.03%) Total Size: 2.29 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
Objective: Report checkout value from generic checkout and new one-time checkout.
This PR does not cover:
These can be tackled in follow-up PRs.
DONE:
sendEventCheckoutValue
function [DONE]sendEventCheckoutValue
function on generic checkout Tier 1/2/3 page load [DONE]TODO:
sendEventCheckoutValue
function on new one-time checkout page loadsendEventCheckoutValue
on new one-time checkout amount change (eg. via amounts selection component)TODO with Options
Option 1 (Delete old
sendEventContributionCartValue
function):sendEventContributionCartValue
functionsendEventContributionCartValue
in support-frontend/assets/helpers/redux/checkout/product/contributionsSideEffects.tsPros: Less code
Cons: This will mean we no longer report Contribution Cart value on the 2-step checkout, which currently affects:
Option 2 (Keep old
sendEventContributionCartValue
function):sendEventContributionCartValue
from 2-step checkoutPros: Continues reporting checkout value from 2-step
Cons: Multiple functions doing kind of the same thing, which is a bit confusing, we could label up the code which can be deleted once the 2-step checkout is deleted.
Option 3 (Replace old
sendEventContributionCartValue
function):sendEventContributionCartValue
with calls to newsendEventCheckoutValue
Pros: Less code as we can delete old code
Cons: Will run into type issues trying to get new
sendEventCheckoutValue
function working with old/new checkoutsTrello Card