Only cancel future reminders #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompretty
force-pushed
the
tp-delete-future-reminders
branch
from
734f5c0
to
0654207
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
The current logic cancels all reminders that haven't already been cancelled. This PR extends that to also not cancel any reminders that have already been sent. As we don't have the exact day the reminder is sent, just the reminder period (year & month), it is possible we could cancel a reminder that has actually been sent e.g
2021-11-012021-11-152021-11-20we cancel all the reminders for a given user2021-11-20is still in the2021-11-01reminder period we will cancel the sent reminderThis doesn't have any user facing implications, it just affects how accurate our db is as a log of what happened.