Fixing 1591: Adding support for object literals in additionalProperties #1613
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves #1591
This is an initial pass, without modifying the deserializers.
What is supported as of this PR:
The
additionalProperties
triggers emission of aMap[String, A]
(eg:case class Bar(foo: Map[String, Bar.Baz])
), as well as the nested definition for theSchema[_]
literal at that position.What needs to be done for full compliance with the spec (I've left a comment to this effect) is to introduce yet another intermediate class type that can hold the
parameters
that may come along with aMapSchema
.What still fails after this change: