-
Notifications
You must be signed in to change notification settings - Fork 10
/
workers.go
630 lines (528 loc) · 16.1 KB
/
workers.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
/*
Copyright 2018-2022 Mailgun Technologies Inc
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package gubernator
// Thread-safe worker pool for handling concurrent Gubernator requests.
// Ensures requests are synchronized to avoid caching conflicts.
// Handle concurrent requests by sharding cache key space across multiple
// workers.
// Uses hash ring design pattern to distribute requests to an assigned worker.
// No mutex locking necessary because each worker has its own data space and
// processes requests sequentially.
//
// Request workflow:
// - A 63-bit hash is generated from an incoming request by its Key/Name
// values. (Actually 64 bit, but we toss out one bit to properly calculate
// the next step.)
// - Workers are assigned equal size hash ranges. The worker is selected by
// choosing the worker index associated with that linear hash value range.
// - The worker has command channels for each method call. The request is
// enqueued to the appropriate channel.
// - The worker pulls the request from the appropriate channel and executes the
// business logic for that method. Then, it sends a response back using the
// requester's provided response channel.
import (
"context"
"io"
"strconv"
"sync"
"sync/atomic"
"github.com/OneOfOne/xxhash"
"github.com/mailgun/holster/v4/errors"
"github.com/mailgun/holster/v4/setter"
"github.com/prometheus/client_golang/prometheus"
"github.com/sirupsen/logrus"
"go.opentelemetry.io/otel/trace"
)
type WorkerPool struct {
hasher workerHasher
workers []*Worker
workerCacheSize int
hashRingStep uint64
conf *Config
done chan struct{}
isClosed atomic.Bool
}
type Worker struct {
name string
conf *Config
cache Cache
getRateLimitRequest chan request
storeRequest chan workerStoreRequest
loadRequest chan workerLoadRequest
addCacheItemRequest chan workerAddCacheItemRequest
getCacheItemRequest chan workerGetCacheItemRequest
}
type workerHasher interface {
// ComputeHash63 returns a 63-bit hash derived from input.
ComputeHash63(input string) uint64
}
// hasher is the default implementation of workerHasher.
type hasher struct{}
// Method request/response structs.
type workerStoreRequest struct {
ctx context.Context
response chan workerStoreResponse
out chan<- *CacheItem
}
type workerStoreResponse struct{}
type workerLoadRequest struct {
ctx context.Context
response chan workerLoadResponse
in <-chan *CacheItem
}
type workerLoadResponse struct{}
type workerAddCacheItemRequest struct {
ctx context.Context
response chan workerAddCacheItemResponse
item *CacheItem
}
type workerAddCacheItemResponse struct {
exists bool
}
type workerGetCacheItemRequest struct {
ctx context.Context
response chan workerGetCacheItemResponse
key string
}
type workerGetCacheItemResponse struct {
item *CacheItem
ok bool
}
var _ io.Closer = &WorkerPool{}
var _ workerHasher = &hasher{}
var workerCounter int64
func NewWorkerPool(conf *Config) *WorkerPool {
setter.SetDefault(&conf.CacheSize, 50_000)
// Compute hashRingStep as interval between workers' 63-bit hash ranges.
// 64th bit is used here as a max value that is just out of range of 63-bit space to calculate the step.
chp := &WorkerPool{
workers: make([]*Worker, conf.Workers),
workerCacheSize: conf.CacheSize / conf.Workers,
hasher: newHasher(),
hashRingStep: uint64(1<<63) / uint64(conf.Workers),
conf: conf,
done: make(chan struct{}),
}
// Create workers.
conf.Logger.Infof("Starting %d Gubernator workers...", conf.Workers)
for i := 0; i < conf.Workers; i++ {
chp.workers[i] = chp.newWorker()
go chp.dispatch(chp.workers[i])
}
return chp
}
func newHasher() *hasher {
return &hasher{}
}
func (ph *hasher) ComputeHash63(input string) uint64 {
return xxhash.ChecksumString64S(input, 0) >> 1
}
func (p *WorkerPool) Close() error {
if !p.isClosed.CompareAndSwap(false, true) {
return nil
}
close(p.done)
return nil
}
// Create a new pool worker instance.
func (p *WorkerPool) newWorker() *Worker {
worker := &Worker{
conf: p.conf,
cache: p.conf.CacheFactory(p.workerCacheSize),
getRateLimitRequest: make(chan request),
storeRequest: make(chan workerStoreRequest),
loadRequest: make(chan workerLoadRequest),
addCacheItemRequest: make(chan workerAddCacheItemRequest),
getCacheItemRequest: make(chan workerGetCacheItemRequest),
}
workerNumber := atomic.AddInt64(&workerCounter, 1) - 1
worker.name = strconv.FormatInt(workerNumber, 10)
return worker
}
// getWorker Returns the request channel associated with the key.
// Hash the key, then lookup hash ring to find the worker.
func (p *WorkerPool) getWorker(key string) *Worker {
hash := p.hasher.ComputeHash63(key)
idx := hash / p.hashRingStep
return p.workers[idx]
}
// Pool worker for processing Gubernator requests.
// Each worker maintains its own state.
// A hash ring will distribute requests to an assigned worker by key.
// See: getWorker()
func (p *WorkerPool) dispatch(worker *Worker) {
for {
// Dispatch requests from each channel.
select {
case req, ok := <-worker.getRateLimitRequest:
if !ok {
// Channel closed. Unexpected, but should be handled.
logrus.Error("workerPool worker stopped because channel closed")
return
}
resp := new(response)
resp.rl, resp.err = worker.handleGetRateLimit(req.ctx, req.request, req.reqState, worker.cache)
select {
case req.resp <- resp:
// Success.
case <-req.ctx.Done():
// Context canceled.
trace.SpanFromContext(req.ctx).RecordError(resp.err)
}
metricCommandCounter.WithLabelValues(worker.name, "GetRateLimit").Inc()
case req, ok := <-worker.storeRequest:
if !ok {
// Channel closed. Unexpected, but should be handled.
logrus.Error("workerPool worker stopped because channel closed")
return
}
worker.handleStore(req, worker.cache)
metricCommandCounter.WithLabelValues(worker.name, "Store").Inc()
case req, ok := <-worker.loadRequest:
if !ok {
// Channel closed. Unexpected, but should be handled.
logrus.Error("workerPool worker stopped because channel closed")
return
}
worker.handleLoad(req, worker.cache)
metricCommandCounter.WithLabelValues(worker.name, "Load").Inc()
case req, ok := <-worker.addCacheItemRequest:
if !ok {
// Channel closed. Unexpected, but should be handled.
logrus.Error("workerPool worker stopped because channel closed")
return
}
worker.handleAddCacheItem(req, worker.cache)
metricCommandCounter.WithLabelValues(worker.name, "AddCacheItem").Inc()
case req, ok := <-worker.getCacheItemRequest:
if !ok {
// Channel closed. Unexpected, but should be handled.
logrus.Error("workerPool worker stopped because channel closed")
return
}
worker.handleGetCacheItem(req, worker.cache)
metricCommandCounter.WithLabelValues(worker.name, "GetCacheItem").Inc()
case <-p.done:
// Clean up.
return
}
}
}
// GetRateLimit sends a GetRateLimit request to worker pool.
func (p *WorkerPool) GetRateLimit(ctx context.Context, rlRequest *RateLimitReq, reqState RateLimitReqState) (*RateLimitResp, error) {
// Delegate request to assigned channel based on request key.
worker := p.getWorker(rlRequest.HashKey())
queueGauge := metricWorkerQueue.WithLabelValues("GetRateLimit", worker.name)
queueGauge.Inc()
defer queueGauge.Dec()
handlerRequest := request{
ctx: ctx,
resp: make(chan *response, 1),
request: rlRequest,
reqState: reqState,
}
// Send request.
select {
case worker.getRateLimitRequest <- handlerRequest:
// Successfully sent request.
case <-ctx.Done():
return nil, ctx.Err()
}
// Wait for response.
select {
case handlerResponse := <-handlerRequest.resp:
// Successfully read response.
return handlerResponse.rl, handlerResponse.err
case <-ctx.Done():
return nil, ctx.Err()
}
}
// Handle request received by worker.
func (worker *Worker) handleGetRateLimit(ctx context.Context, req *RateLimitReq, reqState RateLimitReqState, cache Cache) (*RateLimitResp, error) {
defer prometheus.NewTimer(metricFuncTimeDuration.WithLabelValues("Worker.handleGetRateLimit")).ObserveDuration()
var rlResponse *RateLimitResp
var err error
switch req.Algorithm {
case Algorithm_TOKEN_BUCKET:
rlResponse, err = tokenBucket(ctx, worker.conf.Store, cache, req, reqState)
if err != nil {
msg := "Error in tokenBucket"
countError(err, msg)
err = errors.Wrap(err, msg)
trace.SpanFromContext(ctx).RecordError(err)
}
case Algorithm_LEAKY_BUCKET:
rlResponse, err = leakyBucket(ctx, worker.conf.Store, cache, req, reqState)
if err != nil {
msg := "Error in leakyBucket"
countError(err, msg)
err = errors.Wrap(err, msg)
trace.SpanFromContext(ctx).RecordError(err)
}
default:
err = errors.Errorf("Invalid rate limit algorithm '%d'", req.Algorithm)
trace.SpanFromContext(ctx).RecordError(err)
metricCheckErrorCounter.WithLabelValues("Invalid algorithm").Add(1)
}
return rlResponse, err
}
// Load atomically loads cache from persistent storage.
// Read from persistent storage. Load into each appropriate worker's cache.
// Workers are locked during this load operation to prevent race conditions.
func (p *WorkerPool) Load(ctx context.Context) (err error) {
queueGauge := metricWorkerQueue.WithLabelValues("Load", "")
queueGauge.Inc()
defer queueGauge.Dec()
ch, err := p.conf.Loader.Load()
if err != nil {
return errors.Wrap(err, "Error in loader.Load")
}
type loadChannel struct {
ch chan *CacheItem
worker *Worker
respChan chan workerLoadResponse
}
// Map request channel hash to load channel.
loadChMap := map[*Worker]loadChannel{}
// Send each item to the assigned channel's cache.
MAIN:
for {
var item *CacheItem
var ok bool
select {
case item, ok = <-ch:
if !ok {
break MAIN
}
// Successfully received item.
case <-ctx.Done():
// Context canceled.
return ctx.Err()
}
worker := p.getWorker(item.Key)
// Initiate a load channel with each worker.
loadCh, exist := loadChMap[worker]
if !exist {
loadCh = loadChannel{
ch: make(chan *CacheItem),
worker: worker,
respChan: make(chan workerLoadResponse),
}
loadChMap[worker] = loadCh
// Tie up the worker while loading.
worker.loadRequest <- workerLoadRequest{
ctx: ctx,
response: loadCh.respChan,
in: loadCh.ch,
}
}
// Send item to worker's load channel.
select {
case loadCh.ch <- item:
// Successfully sent item.
case <-ctx.Done():
// Context canceled.
return ctx.Err()
}
}
// Clean up.
for _, loadCh := range loadChMap {
close(loadCh.ch)
// Load response confirms all items have been loaded and the worker
// resumes normal operation.
select {
case <-loadCh.respChan:
// Successfully received response.
case <-ctx.Done():
// Context canceled.
return ctx.Err()
}
}
return nil
}
func (worker *Worker) handleLoad(request workerLoadRequest, cache Cache) {
MAIN:
for {
var item *CacheItem
var ok bool
select {
case item, ok = <-request.in:
if !ok {
break MAIN
}
// Successfully received item.
case <-request.ctx.Done():
// Context canceled.
return
}
cache.Add(item)
}
response := workerLoadResponse{}
select {
case request.response <- response:
// Successfully sent response.
case <-request.ctx.Done():
// Context canceled.
trace.SpanFromContext(request.ctx).RecordError(request.ctx.Err())
}
}
// Store atomically stores cache to persistent storage.
// Save all workers' caches to persistent storage.
// Workers are locked during this store operation to prevent race conditions.
func (p *WorkerPool) Store(ctx context.Context) (err error) {
queueGauge := metricWorkerQueue.WithLabelValues("Store", "")
queueGauge.Inc()
defer queueGauge.Dec()
var wg sync.WaitGroup
out := make(chan *CacheItem, 500)
// Iterate each worker's cache to `out` channel.
for _, worker := range p.workers {
wg.Add(1)
go func(ctx context.Context, worker *Worker) {
defer wg.Done()
respChan := make(chan workerStoreResponse)
req := workerStoreRequest{
ctx: ctx,
response: respChan,
out: out,
}
select {
case worker.storeRequest <- req:
// Successfully sent request.
select {
case <-respChan:
// Successfully received response.
return
case <-ctx.Done():
// Context canceled.
trace.SpanFromContext(ctx).RecordError(ctx.Err())
return
}
case <-ctx.Done():
// Context canceled.
trace.SpanFromContext(ctx).RecordError(ctx.Err())
return
}
}(ctx, worker)
}
// When all iterators are done, close `out` channel.
go func() {
wg.Wait()
close(out)
}()
if ctx.Err() != nil {
return ctx.Err()
}
if err = p.conf.Loader.Save(out); err != nil {
return errors.Wrap(err, "while calling p.conf.Loader.Save()")
}
return nil
}
func (worker *Worker) handleStore(request workerStoreRequest, cache Cache) {
for item := range cache.Each() {
select {
case request.out <- item:
// Successfully sent item.
case <-request.ctx.Done():
// Context canceled.
trace.SpanFromContext(request.ctx).RecordError(request.ctx.Err())
return
}
}
response := workerStoreResponse{}
select {
case request.response <- response:
// Successfully sent response.
case <-request.ctx.Done():
// Context canceled.
trace.SpanFromContext(request.ctx).RecordError(request.ctx.Err())
}
}
// AddCacheItem adds an item to the worker's cache.
func (p *WorkerPool) AddCacheItem(ctx context.Context, key string, item *CacheItem) (err error) {
worker := p.getWorker(key)
queueGauge := metricWorkerQueue.WithLabelValues("AddCacheItem", worker.name)
queueGauge.Inc()
defer queueGauge.Dec()
respChan := make(chan workerAddCacheItemResponse)
req := workerAddCacheItemRequest{
ctx: ctx,
response: respChan,
item: item,
}
select {
case worker.addCacheItemRequest <- req:
// Successfully sent request.
select {
case <-respChan:
// Successfully received response.
return nil
case <-ctx.Done():
// Context canceled.
return ctx.Err()
}
case <-ctx.Done():
// Context canceled.
return ctx.Err()
}
}
func (worker *Worker) handleAddCacheItem(request workerAddCacheItemRequest, cache Cache) {
exists := cache.Add(request.item)
response := workerAddCacheItemResponse{exists}
select {
case request.response <- response:
// Successfully sent response.
case <-request.ctx.Done():
// Context canceled.
trace.SpanFromContext(request.ctx).RecordError(request.ctx.Err())
}
}
// GetCacheItem gets item from worker's cache.
func (p *WorkerPool) GetCacheItem(ctx context.Context, key string) (item *CacheItem, found bool, err error) {
worker := p.getWorker(key)
queueGauge := metricWorkerQueue.WithLabelValues("GetCacheItem", worker.name)
queueGauge.Inc()
defer queueGauge.Dec()
respChan := make(chan workerGetCacheItemResponse)
req := workerGetCacheItemRequest{
ctx: ctx,
response: respChan,
key: key,
}
select {
case worker.getCacheItemRequest <- req:
// Successfully sent request.
select {
case resp := <-respChan:
// Successfully received response.
return resp.item, resp.ok, nil
case <-ctx.Done():
// Context canceled.
return nil, false, ctx.Err()
}
case <-ctx.Done():
// Context canceled.
return nil, false, ctx.Err()
}
}
func (worker *Worker) handleGetCacheItem(request workerGetCacheItemRequest, cache Cache) {
item, ok := cache.GetItem(request.key)
response := workerGetCacheItemResponse{item, ok}
select {
case request.response <- response:
// Successfully sent response.
case <-request.ctx.Done():
// Context canceled.
trace.SpanFromContext(request.ctx).RecordError(request.ctx.Err())
}
}