Merge pull request #1 from guionardo/fix/pipeline

Fix/pipeline

.github/workflows/python-publish.yml

@@ -8,7 +8,7 @@
 
 name: Upload Python Package
 
-on:
+on:  
   release:
     types: [published]
 

gs/__init__.py

@@ -1,5 +1,5 @@
 """Package data"""
-__version__ = '0.1.3'
+__version__ = '0.1.4'
 __tool_name__ = 'py-gstools'
 __description__ = 'Tool classes and functions for Guiosoft projects'
 __author__ = 'Guionardo Furlan'

gs/cache/memory_cache.py

@@ -19,6 +19,7 @@ def get(self, key: str) -> Union[str, None]:
             if valid_until > datetime.datetime.now():
                 return value
             del self.cache[key]
+        return None
 
     def set(self, key: str, value: str,
             ttl: datetime.timedelta = datetime.timedelta(seconds=0)) -> None:

tests/cache/test_cache.py

@@ -10,14 +10,17 @@ class TestCache(unittest.TestCase):
     """Test Caches"""
 
     def test_unknown_cache(self):
+        """Asserts uknown cache type raises exception"""
         with self.assertRaises(Exception):
             get_cache('unknown')
 
     def test_memory_cache(self):
+        """Test memory cache"""
         cache = get_cache('memory')
         self._test_cache(cache, MemoryCache)
 
     def test_file_cache(self):
+        """Test file cache"""
         with tempfile.TemporaryDirectory() as tmpdir:
             cache = get_cache(f'path://{tmpdir}')
             self._test_cache(cache, FileCache)

tests/dotenv/test_dotenv.py

@@ -1,28 +1,33 @@
+"""Test dotenv module"""
+import os
 import unittest
 import tempfile
 
 from gs.dotenv import load_env
 
 
 class TestDotEnv(unittest.TestCase):
+    """Test dotenv"""
 
     def test_just_extra_source(self):
+        """Validates extra_source argument"""
 
-        with self.assertLogs('gs.dotenv', level='INFO') as cm:
+        with self.assertLogs('gs.dotenv', level='INFO') as logs:
             self.assertTrue(
                 load_env(extra_source={'TEST_DOTENV': 'test'}, verbose=True))
             self.assertEqual(
-                cm.output, ['INFO:gs.dotenv:load_env(extra_source={\'TEST_DOTENV\': \'test\'})'])
+                logs.output, ['INFO:gs.dotenv:load_env(extra_source={\'TEST_DOTENV\': \'test\'})'])
 
     def test_envfile(self):
+        """Validates envfile argument"""
         with tempfile.NamedTemporaryFile('w', prefix='.env', delete=True) as tmp:
             tmp.write('TEST_DOTENV=test\n# comment\nTEST_DOTENV2=test2=test3\n')
             tmp.flush()
-            with self.assertLogs('gs.dotenv', level='INFO') as cm:
-                self.assertTrue(
-                    load_env(file_name=tmp.name, verbose=True))
-                self.assertEqual(
-                    cm.output, [f"INFO:gs.dotenv:load_env(file_name={tmp.name}) - {{'TEST_DOTENV': 'test', 'TEST_DOTENV2': 'test2=test3'}}"])
+
+            self.assertTrue(load_env(file_name=tmp.name))
+            self.assertEqual('test', os.environ['TEST_DOTENV'])
+            self.assertEqual('test2=test3', os.environ['TEST_DOTENV2'])
 
     def test_unexistent_file(self):
+        """Validates nonexistent file"""
         self.assertFalse(load_env(file_name='/tmp/nonexistent.env'))