Bump PostCSS to 8.3, resolving CVE-2021-23368 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes PostCSS ReDoS vulnerability. See https://www.npmjs.com/advisories/1693
|
Looks like the CI for Node v6 failed. This is probably due to one of PostCSS 8's breaking changes, which drop support for Node v6, among others:
Pulled from PostCSS 8.0.0 release notes under "Breaking Changes". |
|
What can we do to help to get this merged? |
alex-voznyuk-kovaltchuk-sp
approved these changes
May 15, 2024
alex-voznyuk-kovaltchuk-sp
suggested changes
May 15, 2024
alex-voznyuk-kovaltchuk-sp
approved these changes
May 15, 2024
|
@nmccready @tchetwin @phated Could you please merge it and create a release? |
Co-authored-by: Alex Voznyuk-Kovaltchuk <67268243+alex-voznyuk-kovaltchuk-sp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PostCSS ReDoS vulnerability. See https://www.npmjs.com/advisories/1693
All tests run using
npm run testpass. At a glance, it doesn't look like there are any relevant breaking changes in the PostCSS 8.0.0 release notes.