Update Calibration

[ColmTalbot]

@cdcapano @ahnitz this PR is adding the calibration functionality previously introduced to gwin (gwastro/gwin#63).

This is basically a cut and paste from the code I added there.

I renamed the existing Recalibrate class to PhysicalModel to keep Recalibrate available for the base class.

If/when this is merged I'll open a PR in gwin to update the calibration functionality there to use this.

[duncan-brown]

@ColmTalbot @dfinstad we might want to take this opportunity to rename "physical model" as that's rather generic. How about TimeDomainCalFactors since it really adjusts those?

[ahnitz]

One issue here, is that we've been using the unittest module and not pytest for unit tests. This would pull in another build dependency. @ColmTalbot Any chance this can be converted to unittest, or a good reason we should move to pytest instead?

[ahnitz]

Otherwise, I think this is ready to go.

[cdcapano]

@ahnitz We've been using pytest in gwin... @duncanmmacleod decided to use pytest instead of unittest, I think because it has some better features. Since @ColmTalbot originally wrote this in gwin, the tests he wrote were in pytest. Would it be so bad to support both?

[ahnitz]

Unittest comes with python so doesn't require extra dependencies. The only major reason I know to use pytest is in verson of python < 2.7 where it didn't have as many features. It shouldn't be too hard to convert to a unittest format.

…

On Fri, Aug 3, 2018 at 5:12 AM, Collin Capano ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In test/test_calibration.py <#2268 (comment)>: > @@ -0,0 +1,80 @@ +import pytest @ahnitz <https://github.com/ahnitz> We've been using pytest in gwin... @duncanmmacleod <https://github.com/duncanmmacleod> decided to use pytest instead of unittest, I think because it has some better features. Since @ColmTalbot <https://github.com/ColmTalbot> originally wrote this in gwin, the tests he wrote were in pytest. Would it be so bad to support both? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2268 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACGrRh3WjsBnGusH1JAZOamoIKNBRDJUks5uNBP6gaJpZM4VnAFJ> .

-- Dr. Alexander Nitz Max Planck Institute for Gravitational Physics (Albert Einstein Institute) Callinstrasse 38 D-30167 Hannover, Germany Tel: +49 511 762-17097

[ahnitz]

@ColmTalbot This should be superseded now by #2393. I've gone ahead an updated the unit tests to use the unit test module. Thanks so much for adding this.