add in spline model #2393
Merged
add in spline model #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not squash when merging so that Colm gets credit for his commits. |
Closed
Are we still doing the name thing with the copyright? Should he add his name there as well? |
|
@cmbiwer No harm in doing so. I've just added that in. |
cdcapano
requested changes
Oct 20, 2018
|
@cdcapano Cannot easly fix the getargspec issue. It's a python3 related deprecation. I'm going to ignore that one if that's ok. |
cdcapano
approved these changes
Oct 26, 2018
fixes ws no getargspec fixes more formatting remove unused import
ahnitz
added a commit
to ahnitz/pycbc
that referenced
this pull request
Nov 21, 2018
* add cubic spline calibration * add tests * move calibration test from pytest to unittest * add copyright, small climate fixes fixes ws no getargspec fixes more formatting remove unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the model that Colm Talbot wrote to use unittest for the testing. Supersedes #2268