Feature/range setup fixes #18
Conversation
|
| Name | Link |
|---|---|
| 🔨 Latest commit | db57981 |
Taskfile.yml
Outdated
| - python -m venv .venv # Create a virtual environment | ||
| - source .venv/bin/activate # Activate the virtual environment |
There was a problem hiding this comment.
so, i initially tried this, and unfortunately because Task runs things in subshells, the activation of the venv is borderline impossible (would require massive backflips not worth the price of admission) so i think the venv stuff should maybe come out. but otherwise, fantastic call 🙌🏻
There was a problem hiding this comment.
alternatively, if you disagree, we could leave this all in but people would just need to activate the venv again manually after this step. not sure if that's simpler or more confusing, open to thoughts/ideas.
There was a problem hiding this comment.
ahh yep removed thanks
There was a problem hiding this comment.
maybe a setuptools or poetry package manager might be worthwhile?
There was a problem hiding this comment.
i've noticed poetry adding some extra abstraction and thus confusion to people learning the python flow (from time teaching and consulting), so in the interest of prioritizing understanding over convenience i don't want to go that route BUT -- i'm wondering if maybe rather than a setup step in Task, there's a setup.sh script that does everything for the initial setup automatically just to accelerate people and they can come back to various things more modularly. not as nice as having it at all aligned in Task but perhaps the best compromise available. 🤔
Taskfile.yml
Outdated
| - source .venv/bin/activate # Activate the virtual environment | ||
| - python -m pip install -r requirements.txt | ||
| - dbt deps | ||
| - npm --prefix ./reports install |
There was a problem hiding this comment.
also, we should add pre-commit install to the setup (i need to add information on this to the docs i'm realizing), i realized the requirements.txt changes here didn't get alpha-sorted which means pre-commit didn't run, and that would make sense because i don't call it out in the README or setup tasks!
A range of local tweaks to make it work for someone getting started.
p.s. love the stack.
Maybe we could put dbt into its own folder?