change console error to throw

gwleuverink · Jan 19, 2024 · d1a28a3 · d1a28a3
1 parent 2e211a8
commit d1a28a3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/Components/Import.php b/src/Components/Import.php
@@ -53,7 +53,7 @@ protected function raiseConsoleErrorOrException(BundlingFailedException $e)
 
         return <<< HTML
             <!--[BUNDLE: {$this->as} from '{$this->module}']-->
-            <script data-bundle="{$this->module}">console.error('BUNDLING ERROR: import {$this->module} as {$this->as}')</script>
+            <script data-bundle="{$this->module}">throw 'BUNDLING ERROR: import {$this->module} as {$this->as}'</script>
             <!--[ENDBUNDLE]>-->
         HTML;
     }

diff --git a/tests/Browser/ComponentTest.php b/tests/Browser/ComponentTest.php
@@ -195,6 +195,6 @@ public function it_logs_console_errors_when_debug_mode_disabled()
             HTML)
             ->assertScript(<<< 'JS'
                 document.querySelector('script[data-bundle="~/nonexistent-module"').innerHTML
-            JS, "console.error('BUNDLING ERROR: import ~/nonexistent-module as foo')");
+            JS, "throw 'BUNDLING ERROR: import ~/nonexistent-module as foo'");
     }
 }
diff --git a/tests/Feature/IntegrationTest.php b/tests/Feature/IntegrationTest.php
@@ -113,13 +113,13 @@
         ->not->toThrow(BundlingFailedException::class);
 });
 
-it('raises console error when blade component fails bundling and debug mode is disabled', function () {
+it('logs console error when blade component fails bundling and debug mode is disabled', function () {
     config()->set('app.debug', false);
     $component = new Import('~/foo', 'bar');
 
     expect($component->render())
         ->toContain(
-            'console.error',
+            'throw',
             'BUNDLING ERROR: import ~/foo as bar'
         )
         ->not->toThrow(BundlingFailedException::class);