Feature/css loader #13
Conversation
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules and modified lines of code than 97% of the historic high-risk change sets. The risk is lower since it is an experienced author responsible for 99% of all commits in this repo.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Method InjectCore.php: InjectCore.core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
============================================
+ Coverage 96.95% 97.02% +0.07%
- Complexity 42 43 +1
============================================
Files 6 6
Lines 197 202 +5
============================================
+ Hits 191 196 +5
Misses 6 6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules and modified lines of code than 97% of the historic high-risk change sets. The risk is lower since it is an experienced author responsible for 99% of all commits in this repo.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Method InjectCore.php: InjectCore.core
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules and modified lines of code than 98% of the historic high-risk change sets. The risk is lower since it is an experienced author responsible for 99% of all commits in this repo.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Code Duplication CssLoaderTest.php
- Complex Method InjectCore.php: InjectCore.core
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules and modified lines of code than 98% of the historic high-risk change sets. The risk is lower since it is an experienced author responsible for 99% of all commits in this repo.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Code Duplication CssLoaderTest.php
- Complex Method InjectCore.php: InjectCore.core
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules and modified lines of code than 98% of the historic high-risk change sets. The risk is lower since it is an experienced author responsible for 99% of all commits in this repo.
View detailed results in CodeScene
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules and modified lines of code than 98% of the historic high-risk change sets. The risk is lower since it is an experienced author responsible for 99% of all commits in this repo.
View detailed results in CodeScene
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules and modified lines of code than 98% of the historic high-risk change sets. The risk is lower since it is an experienced author responsible for 99% of all commits in this repo.
View detailed results in CodeScene
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules and modified lines of code than 98% of the historic high-risk change sets. The risk is lower since it is an experienced author responsible for 99% of all commits in this repo.
View detailed results in CodeScene
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules and modified lines of code than 99% of the historic high-risk change sets. The risk is lower since it is an experienced author responsible for 99% of all commits in this repo.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Conditional BundlingFailedException.php: BundlingFailedException.output 🔥
| if ( | ||
| gettype($output) === 'object' && | ||
| property_exists($output, 'id') && | ||
| property_exists($output, 'message') && |
There was a problem hiding this comment.
❌ New issue: Complex Conditional
BundlingFailedException.output has 1 complex conditionals with 3 branches, threshold = 2
Why does this problem occur?
A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell. Read more.
To ignore this warning click here.
There was a problem hiding this comment.
This will be reworked in a separate PR
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules and modified lines of code than 99% of the historic high-risk change sets. The risk is lower since it is an experienced author responsible for 99% of all commits in this repo.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Conditional BundlingFailedException.php: BundlingFailedException.output 🔥
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules and modified lines of code than 99% of the historic high-risk change sets. The risk is lower since it is an experienced author responsible for 99% of all commits in this repo.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Conditional BundlingFailedException.php: BundlingFailedException.output 🔥
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules and modified lines of code than 99% of the historic high-risk change sets. The risk is lower since it is an experienced author responsible for 99% of all commits in this repo.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Conditional BundlingFailedException.php: BundlingFailedException.output 🔥
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules and modified lines of code than 99% of the historic high-risk change sets. The risk is lower since it is an experienced author responsible for 99% of all commits in this repo.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Conditional BundlingFailedException.php: BundlingFailedException.output 🔥
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The change involves more modules and modified lines of code than 99% of the historic high-risk change sets. The risk is lower since it is an experienced author responsible for 99% of all commits in this repo.
View detailed results in CodeScene
🚩 Declining Code Health (highest to lowest):
- Complex Conditional BundlingFailedException.php: BundlingFailedException.output 🔥
This PR adds a basic CSS loader that should cover most use cases (needs lightningcss as a dependency)
Sass is also supported, but needs to be installed separately