You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The concern is that a main model type called Work, despite the use of namespaces, has the potential to make the code more ambiguous (or worse), as it is the same name as the curation_concerns Work model.
Consider a name like GwssWork, or similar, to help distinguish.
Recommend starting by creating a brand new app to identify code that should reflect the new class name. Then work (no pun intended) through the rest of the gwss-specific code for instances of the Work model.
The text was updated successfully, but these errors were encountered:
The concern is that a main model type called Work, despite the use of namespaces, has the potential to make the code more ambiguous (or worse), as it is the same name as the curation_concerns Work model.
https://github.com/gwu-libraries/scholarspace-sufia7/blob/master/app/models/work.rb
The model was originally created following exactly the example https://github.com/projecthydra/sufia#generate-a-primary-work-type ; still, it may not be a good idea.
Consider a name like GwssWork, or similar, to help distinguish.
Recommend starting by creating a brand new app to identify code that should reflect the new class name. Then work (no pun intended) through the rest of the gwss-specific code for instances of the Work model.
The text was updated successfully, but these errors were encountered: