Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider refactoring Work model name #45

Open
kerchner opened this issue Jan 23, 2017 · 0 comments
Open

Consider refactoring Work model name #45

kerchner opened this issue Jan 23, 2017 · 0 comments
Assignees
Milestone

Comments

@kerchner
Copy link
Member

The concern is that a main model type called Work, despite the use of namespaces, has the potential to make the code more ambiguous (or worse), as it is the same name as the curation_concerns Work model.

https://github.com/gwu-libraries/scholarspace-sufia7/blob/master/app/models/work.rb

The model was originally created following exactly the example https://github.com/projecthydra/sufia#generate-a-primary-work-type ; still, it may not be a good idea.

Consider a name like GwssWork, or similar, to help distinguish.

Recommend starting by creating a brand new app to identify code that should reflect the new class name. Then work (no pun intended) through the rest of the gwss-specific code for instances of the Work model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant