Check non root error #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iocotron simulation Add: - VlasovPoissonSolver: solves Poisson equation and computes electric field in XY; - PoissonRHSFunction: creates a spline of the RHS and returns its values at a coordinate; - test files for VlasovPoissonSolver; README.md in src/geometryRTheta/polar_poisson/ and tests/geometryRTheta/polar_poisson/ folders. Modify: - PolarSplineFEMPoissonSolver: add an operator() which returns the B-splines coefficients of the solution, and removes the template of the class.
* updates the `simulations/geometryXVx/sheath/README.md` with more explanation concerning how to verify the sheath simulations using the fluid conservation equations. * creates the `simulations/geometryXVx/sheath/verification_simulation` folder to provide a yaml file with reference parameters that can be used to verify the gpu porting of the code for instance. * the `simulations/geometryXVx/sheath/verification_simulation` also contains plots of the conservation equations.
* updates the `simulations/geometryXVx/sheath/README.md` with more explanation concerning how to verify the sheath simulations using the fluid conservation equations.
* creates the `simulations/geometryXVx/sheath/verification_simulation` folder to provide a yaml file with reference parameters that can be used to verify the gpu porting of the code for instance.
* the `simulations/geometryXVx/sheath/verification_simulation` also contains plots of the conservation equations.
* updates the `simulations/geometryXVx/sheath/README.md` with more explanation concerning how to verify the sheath simulations using the fluid conservation equations.
* creates the `simulations/geometryXVx/sheath/verification_simulation` folder to provide a yaml file with reference parameters that can be used to verify the gpu porting of the code for instance.
* the `simulations/geometryXVx/sheath/verification_simulation` also contains plots of the conservation equations.
Modify the src/geometryRTheta/advection/ folder: * Change IFootFinder to SplineFootFinder and add a FootFinder base class. * Make the IFootFinder and the ITimeStepper classes (and child classes) const. * IFootFinder advects the feet and BslAdvectionRP uses the result and interpolate the function. * IAdvectionRP class (+child class) are put const.
Make the calculation of the right hand side of the Poisson equation (the calculation of the charge density) parametrisable. This is achieved by creating an Interface class `IChargeDensityCalculator`. The existing classes are documented and renamed for clarity: * `ChargeDensityCalculator` -> `SplineChargeDensityCalculator` * `ChargeDensityCalculatorSplineless` -> `ChargeDensityCalculator`
Add a test label "ResultsNotTested" to filter out tests which do not test their results. These tests are not run on the GPU. Remove `assert False` in Python files in `tests/geometryRTheta/` which causes tests to fail when there are warnings (these tests also contain `assert p.returncode == 0` so there is no risk of them trying to treat results of a failing code.
Vlasov for Sheath is completly ported on GPU. Batched classes and interfaces had to be introduced because we need to continue supporting non-batched splines for a while, as non-periodic BC are not supported in the Batched version of the splines which is in DDC. In the future non-batched classes should be removed and renamed by removing the "Batched" suffix.
Modify RefinedDiscreteMapping and add pseudo Cartesian Jacobian matrix in the class.
Generalise the script `display_all_errors_for_gtest.py` so it can handle both the `advection_ALL` executable and the `advection_*_*_*` executables. Print the test name in the `advection_*_*_*` executables. Compile all `advection_*_*_*` executables which are useful for the tests (the same test cases as before but only with the crank-nicolson time integrator) and test each case individually
Add a basic linter to check markdown files. GitLab only supports a subset of markdown for equations so it is important to use a linter to have readable README files. The file `ci_tools/markdown_linter.py` can be used to check the validity of the file (this is done in the test) or with the argument `--fix` to fix the markdown file inplace.
Add diocotron simulation and the associated predcorr: * add simulation/geometryRTheta/diocotron folder with main function of the simulation; savings in .h5 files; readme. * add src/geometryRTheta/time_solver with ITimeSolverRP, BslPredCorrRP, BslExplicitPredCorrRP and BslImplicitPredCorrRP predictor-corrector methods. * add src/geometryRTheta/initialization with DiocotronDensitySolution. * add post-process/PythonScripts/geometryRTheta/diocotron with animation_rho_phi.py, display_L2_norms.py, mass_conservation.py. * add post-process/PythonScripts/gysdata/data_structure_diocotron.yaml * add some README.md in simulations, simulations/geometryXVx, tests.
Fix an implementation problem, inout_data was overrided before being used.
Update naming conventions in XY geometry See merge request gysela-developpers/gyselalibxx!633
Unbatched solvers in MatrixBatchCsr Closes #295 See merge request gysela-developpers/gyselalibxx!598
Update naming conventions in PDE solvers See merge request gysela-developpers/gyselalibxx!631
Realign MatrixBatch classes on ddc::SplinesLinearSolver Closes #305 See merge request gysela-developpers/gyselalibxx!635
Stop mixing device/host conventions for species See merge request gysela-developpers/gyselalibxx!639
…transformation' into 'main' Add an Index transformation operator in EdgeTransformation Closes #298 See merge request gysela-developpers/gyselalibxx!612
ddc sync See merge request gysela-developpers/gyselalibxx!641
Add cppcheck to docker See merge request gysela-developpers/gyselalibxx!645
Bounds on which commit to accept from upstream spack to avoid version incompatibilities See merge request gysela-developpers/gyselalibxx!644
Renaming cleanup Part 1 See merge request gysela-developpers/gyselalibxx!638
Add MultiPatchConnectivity class See merge request gysela-developpers/gyselalibxx!625
Workaround for sheath simulation divergence See merge request gysela-developpers/gyselalibxx!647
Remove -Wunused-local-typedefs in src/utils/transpose See merge request gysela-developpers/gyselalibxx!648
…nnectivity' into 'main' Reduce number of executables in tests/multipatch/connectivity. Closes #326 See merge request gysela-developpers/gyselalibxx!651
Stop using deprecated DDC alias See merge request gysela-developpers/gyselalibxx!649
Re-enable Maxwellian test See merge request gysela-developpers/gyselalibxx!650
Create MultipatchField storage class See merge request gysela-developpers/gyselalibxx!636
EmilyBourne
force-pushed
the
ebourne_test_non_root
branch
from
4740c35
to
665e234
Compare
EmilyBourne
force-pushed
the
ebourne_test_non_root
branch
from
e8c7c06
to
1932d63
Compare
EmilyBourne
force-pushed
the
main
branch
2 times, most recently
from
0fcd538
to
2a968f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.