-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#79): MetaRoot200Response #80
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #80 +/- ##
===========================================
+ Coverage 18.18% 52.22% +34.04%
===========================================
Files 7 7
Lines 66 90 +24
===========================================
+ Hits 12 47 +35
+ Misses 54 43 -11 ☔ View full report in Codecov by Sentry. |
@l3r8yJ ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h1alexbel looks good to me!
but it's quite big PR, might skip something
@rultor merge |
@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here |
@h1alexbel Done! FYI, the full log is here (took me 17min) |
In this pull, I've introduced home endpoint handling using
MetaRoot200Response
generated struct.@l3r8yJ take a look, please
closes #79
PR-Codex overview
This PR adds reqwest dependency, verbose output option, ServerConfig struct, 404 logging, integration tests, and updates home endpoint response URLs.
Detailed summary
reqwest
dependency for HTTP requests--v
option for verbose outputServerConfig
struct with host and port fieldsServerConfig
host and port