Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#79): MetaRoot200Response #80

Merged
merged 7 commits into from
Jul 18, 2024
Merged

feat(#79): MetaRoot200Response #80

merged 7 commits into from
Jul 18, 2024

Conversation

h1alexbel
Copy link
Owner

@h1alexbel h1alexbel commented Jul 16, 2024

In this pull, I've introduced home endpoint handling using MetaRoot200Response generated struct.

@l3r8yJ take a look, please

closes #79


PR-Codex overview

This PR adds reqwest dependency, verbose output option, ServerConfig struct, 404 logging, integration tests, and updates home endpoint response URLs.

Detailed summary

  • Added reqwest dependency for HTTP requests
  • Implemented --v option for verbose output
  • Introduced ServerConfig struct with host and port fields
  • Added logging for 404 NOT FOUND requests
  • Integrated integration tests for home endpoint
  • Updated home endpoint response URLs to use ServerConfig host and port

The following files were skipped due to too many changes: server/src/routes/home.rs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 79.54545% with 9 lines in your changes missing coverage. Please review.

Project coverage is 52.22%. Comparing base (8a6d4b8) to head (782dae0).
Report is 2 commits behind head on master.

Files Patch % Lines
server/src/lib.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #80       +/-   ##
===========================================
+ Coverage   18.18%   52.22%   +34.04%     
===========================================
  Files           7        7               
  Lines          66       90       +24     
===========================================
+ Hits           12       47       +35     
+ Misses         54       43       -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h1alexbel h1alexbel requested a review from l3r8yJ July 16, 2024 16:10
@h1alexbel
Copy link
Owner Author

@l3r8yJ ping

Copy link
Collaborator

@l3r8yJ l3r8yJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h1alexbel looks good to me!

but it's quite big PR, might skip something

@h1alexbel
Copy link
Owner Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jul 18, 2024

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 6932d8b into master Jul 18, 2024
14 checks passed
@rultor
Copy link
Collaborator

rultor commented Jul 18, 2024

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 17min)

@h1alexbel h1alexbel deleted the 79-root branch July 18, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

return openapi::models::MetaRoot200Response from home endpoint
3 participants