Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

74 #90

Merged
merged 3 commits into from
Jul 21, 2024
Merged

74 #90

merged 3 commits into from
Jul 21, 2024

Conversation

l3r8yJ
Copy link
Collaborator

@l3r8yJ l3r8yJ commented Jul 21, 2024

closes #74

@h1alexbel take a look, please


PR-Codex overview

This PR focuses on implementing clippy configuration to reject unwrap() calls throughout the codebase, and minor code improvements.

Detailed summary

  • Added unwrap_used = "deny" in lints.clippy section in Cargo.toml
  • Replaced unwrap() calls with ? operator to handle errors gracefully
  • Removed unnecessary imports and commented-out code
  • Updated comments and documentation for clarity

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.22%. Comparing base (977aab6) to head (529eece).

Files Patch % Lines
server/src/objects/user.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   52.22%   52.22%           
=======================================
  Files           7        7           
  Lines          90       90           
=======================================
  Hits           47       47           
  Misses         43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@l3r8yJ l3r8yJ requested a review from h1alexbel July 21, 2024 12:42
Copy link
Owner

@h1alexbel h1alexbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l3r8yJ good one

@h1alexbel h1alexbel merged commit 6874315 into master Jul 21, 2024
13 of 14 checks passed
@h1alexbel h1alexbel deleted the 74 branch July 21, 2024 13:19
@h1alexbel h1alexbel restored the 74 branch July 21, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

user.rs:44-46: Configure clippy to reject code with...
2 participants