Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update of h5p-chart. #46

Open
wants to merge 64 commits into
base: master
Choose a base branch
from
Open

Update of h5p-chart. #46

wants to merge 64 commits into from

Conversation

eddiman
Copy link

@eddiman eddiman commented Feb 26, 2021 •
edited
Loading

New update:

  • Added "Extended bar chart" - includes features such as titles for chart and axes, color override ++
  • Added "Line chart" - includes new chart type.
  • Updated translation json files with new semantics structure
  • Translations for en, nb, nn and pt-br included.

eddiman and others added 30 commits February 5, 2021 15:01
@eddiman
added new type of chart, added support for axes title in extendedBarC…
2766181 
…hart
@eddiman
added y axis ticks in extended bar chart, fixed issues with tick and …
7ebd047 
…text alignment with bars, added en and nb translation for new fields
@eddiman
removed debug comments and logging, added some code comments
f14990d
@eddiman
added support for chart title, addded more var and function comments,…
e64335c 
… removed debug logging in chart.js
@eddiman
replaced all double quotation with the single quotation mark to be in…
a413f37 
… line with the quotation convention in project
@eddiman
added language translations to norwegian b
748beb4
@eddiman
fixed minor issues
89181ab
@eddiman
Merge pull request #1 from NDLANO/feature/barchart-extension
592dbd1 
Feature/barchart extension
@eddiman
added support for line chart
73331ea
@eddiman
added color override support and hover indicator on line chart
d560d02
@eddiman
added minor fixes to labels on line diagram
ea46558
@eddiman
added comments to line chart
2def298
@eddiman
added translations
e6ac302
@eddiman
fixed more comments in line chart
c9bcfa8
@eddiman
Merge pull request #2 from NDLANO/feature/line-chart
ef0f7b8 
Feature/line chart
@eddiman
fixed nb lang support, minor changes in semantics, and fixed .en json…
a2c3c17 
… to same structure as semantics
@eddiman
restructured semantics for easier adding missing fields to rest of la…
940da39 
…ng files, also translated pt-br
@eddiman
added missing pt-br translation
7a520b0
@eddiman
removed unnecessary lines in lang jsons
a7ec45d
@eddiman
Merge pull request #4 from NDLANO/fix/lang-fix
7424787 
Fix/lang fix
@kentis
bump patch version
3247fbc
@kentis
Merge pull request #5 from NDLANO/feature/bump_patch_version
95550b0 
bump patch version
@eddiman
fixed default color for line and offsets for no chart title and y axi…
31a557f 
…s ticks
@eddiman
added default color to lineGroup
8bcfaaa
@eddiman @boyum
Update line.js inline condittionals
72b5d96 
Co-authored-by: Sindre Bøyum <boyum@users.noreply.github.com>
@eddiman
Merge pull request #6 from NDLANO/fix/chart-offset-and-color
09f9fc7 
fixed default color for line and offsets for no chart title and y axi…
@eddiman
fixed offset for chart when no chart is present
4233c88
@eddiman
Merge pull request #7 from NDLANO/fix/extended-bar-no-title-offset
7b433cb 
fixed offset for chart when no chart is present
@eddiman
fixed a minor offset issue of x axis tick when chart title is not def…
f0d4c7d 
…ined
@eddiman
Merge pull request #8 from NDLANO/fix/offset-x-axis-tick
4fb7e4e 
fixed a minor offset issue of x axis tick when chart title is not defined
eddiman and others added 26 commits March 11, 2021 17:15
@eddiman
cleaned up xAxis group translation var setting
dc8cea1
@eddiman
Merge branch 'master' into feature/extended-bar-upgrade
4a45a56
@eddiman
added some comments for explaining som vars
e93d089
@eddiman
removed some old comments in line.js
4a8859d
@eddiman
bumped patchversion
5d183a2
@boyum
Merge remote-tracking branch 'origin/master' into feature/extended-ba…
278aed9 
…r-upgrade
@eddiman
fixed line chart offsett issue
3c8bc4e
@eddiman
added horizontal padding
2f9fa37
@eddiman
added horizontal padding, moved bar texts to top of bar, changed defa…
41973bd 
…ult font color
@eddiman @boyum
Update line.js
ece74bf 
Co-authored-by: Sindre Bøyum <boyum@users.noreply.github.com>
@eddiman
Merge pull request #12 from NDLANO/fix/line-chart-offset
4e37939 
Fix/line chart offset
@eddiman
Merge pull request #11 from NDLANO/feature/extended-bar-upgrade
523cd84 
Feature/extended bar upgrade
@eddiman
bumped patchnumber and added support for showWhen widget when chart i…
ea5dfbb 
…s used without course-presentation
@eddiman
fixed height issue when tooletip text height is defined by external s…
b717099 
…tyle sheet
@eddiman
css styling for fixing height issue when tooletip text height is defi…
860446d 
…ned by external style sheet
@eddiman
fixed minor hover issue
9bd1370
@eddiman
fixed issue with bar text label alignment
4438e63
@eddiman
fixed vertical padding on line chart, made correction on yaxis title …
5fe2954 
…padding
@eddiman
fixed font sizing
ee9b472
@eddiman
Merge pull request #13 from NDLANO/feature/distance-fixing
515e246 
fixed font
@boyum
Merge branch 'master' of https://github.com/h5p/h5p-chart into h5p-ma…
644cc40 
…ster
@boyum
Merge pull request #15 from NDLANO/h5p-master
2e0a1b4
adding color palette to charts
cac84e9
@EivinS
Merge pull request #16 from NDLANO/add-color-palette-to-charts
4366394 
adding color palette to charts
making every chart-type scale by default
4e3a9c7
@EivinS
Merge pull request #17 from NDLANO/fix/scale-chart
3acc258 
making every chart-type preserve aspect ratio
@boyum boyum mentioned this pull request Jun 30, 2021
Closed
@otacke otacke deleted the branch h5p:master March 14, 2024 17:31
@otacke otacke deleted the master branch March 14, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eddiman @kentis @boyum @EivinS @otacke