-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/code review #141
base: main
Are you sure you want to change the base?
feat/code review #141
Commits on Feb 4, 2024
-
The MerkleTree contract has no comments, and it’s difficult to ascert…
…ain the origins and meanings of various hashes and values, such as those in poseidon-zeros and blake-zeros. The tests focus solely on successful scenarios (using ‘except’) and neglect failure cases (which would use ‘expect-failure’)
Configuration menu - View commit details
-
Copy full SHA for 38f8ca3 - Browse repository at this point
Copy the full SHA 38f8ca3View commit details -
The repository’s contracts directory includes redundant or outdated f…
…iles, like the poseidon directory
Configuration menu - View commit details
-
Copy full SHA for a152917 - Browse repository at this point
Copy the full SHA a152917View commit details -
The repository’s contracts directory includes redundant or outdated f…
…iles, like the poseidon directory
Configuration menu - View commit details
-
Copy full SHA for c30fa8d - Browse repository at this point
Copy the full SHA c30fa8dView commit details -
The project structure, as outlined in the Readme.md, seems incomplete…
…. It fails to mention certain aspects like ‘transact’, for example
Configuration menu - View commit details
-
Copy full SHA for ce09a2e - Browse repository at this point
Copy the full SHA ce09a2eView commit details -
The reliance on JavaScript for generating contracts and files may not…
… be the best approach. While it can be utilized for initial generation, the final versions should be committed to the repository
Configuration menu - View commit details
-
Copy full SHA for b9e4c4d - Browse repository at this point
Copy the full SHA b9e4c4dView commit details -
- The contract ‘opact’ has no explanatory comments, requires a descri…
…ption. The tests in ‘transact-tests.repl’ feature numerous commented-out lines, and there requires more test cases. Overall, there is an almost complete absence of code comments. - The usage of several formal verification annotations is noted, but nothing is checked against. - The test cases could benefit from being more comprehensive.
Configuration menu - View commit details
-
Copy full SHA for e4677c0 - Browse repository at this point
Copy the full SHA e4677c0View commit details -
The Interface (gas-payer-v1) and Verifier (groth16-verifier) have no …
…comments please add. Additionally, the test suite requires more explanatory comments
Configuration menu - View commit details
-
Copy full SHA for d063d7b - Browse repository at this point
Copy the full SHA d063d7bView commit details -
The MerkleTree contract has no comments, and it’s difficult to ascert…
…ain the origins and meanings of various hashes and values, such as those in poseidon-zeros and blake-zeros. The tests focus solely on successful scenarios (using ‘except’) and neglect failure cases (which would use ‘expect-failure’)
Configuration menu - View commit details
-
Copy full SHA for f4da17e - Browse repository at this point
Copy the full SHA f4da17eView commit details
Commits on Feb 5, 2024
-
The contract ‘opact’ has no explanatory comments, requires a descript…
…ion. The tests in ‘transact-tests.repl’ feature numerous commented-out lines, and there requires more test cases. Overall, there is an almost complete absence of code comments
Configuration menu - View commit details
-
Copy full SHA for 6ff26c0 - Browse repository at this point
Copy the full SHA 6ff26c0View commit details
Commits on Feb 6, 2024
-
The contract ‘opact’ has no explanatory comments, requires a descript…
…ion. The tests in ‘transact-tests.repl’ feature numerous commented-out lines, and there requires more test cases. Overall, there is an almost complete absence of code comments
Configuration menu - View commit details
-
Copy full SHA for a250395 - Browse repository at this point
Copy the full SHA a250395View commit details