Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidation of Wemos.ino and WifiShield.ino #17

Open
dl1com opened this issue Apr 1, 2018 · 1 comment
Open

Consolidation of Wemos.ino and WifiShield.ino #17

dl1com opened this issue Apr 1, 2018 · 1 comment
Assignees
Milestone

Comments

@dl1com
Copy link

dl1com commented Apr 1, 2018

Depending on the controller hardware, the user has to choose between Wemos.ino and WifiShield.ino in the /examples folder.
Although they take care of special prerequisites caused by the different hardware, large parts of the code are pretty similar.
To avoid the necessity of fixing bug or introducing a feature in two separate *.ino files, it should be evaluated how far these projects could be merged into a single sketch.

@thgeorgiou
Copy link
Member

This is a good idea, we can use #ifdef to redefine the function that sends data for the ESP8266 since that's the main difference.

@thgeorgiou thgeorgiou added this to the Version 1.0 milestone Apr 2, 2018
@thgeorgiou thgeorgiou self-assigned this Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants