(Showcase) Fallback to playing project video from URL #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slashtechno is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
arnav-kr
suggested changes
Aug 25, 2024
|
|
||
| const isYouTubeLink = youtubeLink.includes('youtube.com') || youtubeLink.includes('youtu.be'); | ||
| if (isYouTubeLink) { | ||
| const youtubeID = youtubeLink.split('v=')[1]; |
There was a problem hiding this comment.
youtu.be links don't have v query param, thus no youtu.be links would render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only YouTube videos are supported for the project demo.
This PR makes
YoutubeRendererfallback to playing from a URL if, for example, a link from#cdnor a raw GItHub link is set.I wasn't sure how to test it as projects are pulled from Airtable, however.