Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added extra info to "free domains" #822

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Conversation

P1xelC0da
Copy link
Contributor

No description provided.

Copy link
Member

@bellesea bellesea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, cc @hackclub/bank-engineering or @hackclub/bank-ops for review as well! :)

@sampoder
Copy link
Member

sampoder commented Jul 3, 2023

personally, this feels a bit verbose to me. I think most domains fall under $20 anyways

@P1xelC0da
Copy link
Contributor Author

P1xelC0da commented Jul 5, 2023 via email

@sampoder
Copy link
Member

sampoder commented Aug 6, 2023

hey! looks like this PR has gone inactive, I'm going to close it

@sampoder sampoder closed this Aug 6, 2023
@P1xelC0da
Copy link
Contributor Author

P1xelC0da commented Aug 6, 2023 via email

@zachlatta zachlatta reopened this Aug 7, 2023
@zachlatta zachlatta merged commit aecb462 into hackclub:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants