Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue195(add i18n config) 2 #231

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add issue195(add i18n config) 2 #231

wants to merge 6 commits into from

Conversation

mashharuki
Copy link
Collaborator

@mashharuki mashharuki commented Jan 1, 2025

add i18n config

Description

i18nの設定を加え直しました!
また、検証用のサンプルページも追加しました!
他のページもボタン押したりできます!

Fixes #195

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

スクリーンショット 2025-01-01 20 51 31 スクリーンショット 2025-01-01 20 52 12

If applicable, add screenshots to help explain your problem.

@mashharuki mashharuki marked this pull request as ready for review January 1, 2025 11:57
@mashharuki mashharuki requested a review from yu23ki14 January 1, 2025 11:59
@mashharuki
Copy link
Collaborator Author

@yawn-c111 さんによるとエラーが起きているらしい・・・・

@mashharuki mashharuki added the help wanted Extra attention is needed label Jan 8, 2025
@yu23ki14
Copy link
Member

yu23ki14 commented Jan 8, 2025

@mashharuki
mainをマージすると一応うまくいきますが、こんな感じですべてのコンポーネントが2回レンダリングされますね。
image

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
toban 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 2:10pm
toban-1736345420524-PIHX 🛑 Canceled (Inspect) Jan 8, 2025 2:10pm

@mashharuki
Copy link
Collaborator Author

スクリーンショット 2025-01-08 23 39 33 スクリーンショット 2025-01-08 23 39 45 スクリーンショット 2025-01-08 23 39 56

entry.client.tsx で余計なことしてたみたいです!
コメントアウトしたら1回分しか出なくなりました!

@mashharuki mashharuki changed the title Add issue195 2 Add issue195(add i18n config) 2 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

フロントエンド: Remixでのi18nの調査と検証
2 participants