Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impliment Makefile #422

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Impliment Makefile #422

merged 2 commits into from
Aug 10, 2023

Conversation

MattPereira
Copy link
Contributor

@MattPereira MattPereira commented Aug 4, 2023 •
edited
Loading

Fixes #421

Changes

  • Removed alias bash script and txt file
  • Replaced with Makefile

Details

  • The short hand aliases like start: and stop: are called "targets"
  • All targets can be run with make <target>

blulady
blulady approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@blulady blulady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR successfully donverts alias.sh & alias-config.txt into a Makefile. The code is clean & concise. The commits are clean and pertinent. The server works when docker-compose up is run. Looks good!!

bzzz-coding
bzzz-coding approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@bzzz-coding bzzz-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MattPereira Thanks for working on this issue ❤️ ! The code is super easy to read and the make commands work as expected. 🚀 ✨

@MattPereira MattPereira merged commit dd1dfc2 into hackforla:main Aug 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzzz-coding bzzz-coding bzzz-coding approved these changes

@blulady blulady blulady approved these changes

@t-will-gillis t-will-gillis Awaiting requested review from t-will-gillis

@bennyv8 bennyv8 Awaiting requested review from bennyv8

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert alias bash script into Makefile
3 participants
@MattPereira @blulady @bzzz-coding